From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752077AbdBBXgt (ORCPT ); Thu, 2 Feb 2017 18:36:49 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:50868 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751720AbdBBXgs (ORCPT ); Thu, 2 Feb 2017 18:36:48 -0500 Subject: Re: [PATCH 2/4] selftests, x86, protection_keys: remove dead code To: Dave Hansen , linux-kernel@vger.kernel.org References: <20170202232842.C3C30DB2@viggo.jf.intel.com> <20170202232845.83211A3D@viggo.jf.intel.com> Cc: x86@kernel.org, Shuah Khan From: Shuah Khan Message-ID: Date: Thu, 2 Feb 2017 16:36:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170202232845.83211A3D@viggo.jf.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/02/2017 04:28 PM, Dave Hansen wrote: > From: Shuah Khan > > Remove commented out calls to pkey_get(). > > Signed-off-by: Shuah Khan > Signed-off-by: Dave Hansen Hi Dave, This patches is already in linux-kselftest next for 4.11 Is there a reason why you chose to resend these. -- Shuah > --- > > b/tools/testing/selftests/x86/protection_keys.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff -puN tools/testing/selftests/x86/protection_keys.c~selftests-x86-protection-keys-remove-dead-code tools/testing/selftests/x86/protection_keys.c > --- a/tools/testing/selftests/x86/protection_keys.c~selftests-x86-protection-keys-remove-dead-code 2017-02-02 15:27:13.329130196 -0800 > +++ b/tools/testing/selftests/x86/protection_keys.c 2017-02-02 15:27:13.333130376 -0800 > @@ -1114,11 +1114,6 @@ void test_pkey_syscalls_on_non_allocated > err = sys_pkey_free(i); > pkey_assert(err); > > - /* not enforced when pkey_get() is not a syscall > - err = pkey_get(i, 0); > - pkey_assert(err < 0); > - */ > - > err = sys_pkey_free(i); > pkey_assert(err); > > @@ -1133,11 +1128,6 @@ void test_pkey_syscalls_bad_args(int *pt > int err; > int bad_pkey = NR_PKEYS+99; > > - /* not enforced when pkey_get() is not a syscall > - err = pkey_get(bad_pkey, bad_flag); > - pkey_assert(err < 0); > - */ > - > /* pass a known-invalid pkey in: */ > err = sys_mprotect_pkey(ptr, PAGE_SIZE, PROT_READ, bad_pkey); > pkey_assert(err); > _ >