From: Krzysztof Kozlowski <krzk@kernel.org>
To: feng.wei8@zte.com.cn, robert.moore@intel.com
Cc: rafael.j.wysocki@intel.com, lenb@kernel.org,
linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPICA: Replace deprecated strncpy() with strscpy()
Date: Mon, 17 Mar 2025 09:19:27 +0100 [thread overview]
Message-ID: <c5cf8522-8967-40f5-9f7c-525ff535875c@kernel.org> (raw)
In-Reply-To: <20250317143806244wrGxYdlssPbWp7T7W5Gbr@zte.com.cn>
On 17/03/2025 07:38, feng.wei8@zte.com.cn wrote:
> diff --git a/drivers/acpi/acpica/utnonansi.c b/drivers/acpi/acpica/utnonansi.c
> index ff0802ace19b..1da9b8246011 100644
> --- a/drivers/acpi/acpica/utnonansi.c
> +++ b/drivers/acpi/acpica/utnonansi.c
> @@ -168,8 +168,7 @@ void acpi_ut_safe_strncpy(char *dest, char *source, acpi_size dest_size)
> {
> /* Always terminate destination string */
>
> - strncpy(dest, source, dest_size);
> - dest[dest_size - 1] = 0;
> + strscpy(dest, source, dest_size);
What is the point of this function now?
Can ZTE slow down and address the feedback first?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-17 8:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 6:38 feng.wei8
2025-03-17 8:19 ` Krzysztof Kozlowski [this message]
2025-03-26 15:06 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5cf8522-8967-40f5-9f7c-525ff535875c@kernel.org \
--to=krzk@kernel.org \
--cc=acpica-devel@lists.linux.dev \
--cc=feng.wei8@zte.com.cn \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®