From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f43.google.com (mail-oo1-f43.google.com [209.85.161.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90BBD2D77F3 for ; Wed, 2 Jul 2025 19:54:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751486077; cv=none; b=o7E9pDW0k031ANBbdXX/WZ5Tg4D7izXIc/9Mq+s/VPAOGSywqVSsWdIh0lO5F7zVJLZ5QaQID/h0qukxUOmsOiORlFbf0sUHtWaGjm3WVwdjExkvrXwGOHLEzy5l80GBYggsp5CgTTwCX6uXV/Ouk1U35vWhkFej7fkhvTTryFk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751486077; c=relaxed/simple; bh=WKSnMSttL8oH8Oe5vAQfNUn0TlrCgh4B+Anf0JHHdZs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pRYL2ZOHBa8zJoRxyVGr9d/hsSHDCWkS2xEUPW8ucyljps+mL2vOegeebyA77ByIs/Azl+/JnWzQt347d8+XXA1pUgV4hetY9eaZ/GJSZdmsTGoRC0bwOfV6eweJXnpTvRw7goyYQ02ijE5rXzCzAcO8daD4grBVXNOoNE3E+9k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=a6L0xqg+; arc=none smtp.client-ip=209.85.161.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="a6L0xqg+" Received: by mail-oo1-f43.google.com with SMTP id 006d021491bc7-611e455116aso2024443eaf.1 for ; Wed, 02 Jul 2025 12:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751486074; x=1752090874; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=giyunrX2+D6X+A6e6UeKZhe7Cg6ipMHEWvo2VSb9DY0=; b=a6L0xqg+Fj+4LSnhDzSC9IEEBI76Mhy1BCiNVMD1oqt+CHAbPhXXne5zOBLGBCIjwg cwKDIh7RWrBuArlNvAEL7CtaWoxucNgPlAwGk3oH9E9IfG+uNOIA+JGqnFRduYNnZlkV mz8MYcjChXvESizfEsolqhSPyiA4qcNDFC0wkTxVZ0qc7CsIbeoRSsLyqgIl6hO+plKu DZLKPcOuaclSVODlh7xZVjuakHPIn5UvKPbV0EWG0xI8EuYEztgO1A/XkOuQGJN+1win zEv/YDfPCMLwadPwwgnRzXC/z7G50xi/cPTXwX/Fq0JuJyKpqV2EnLJDea69blV6xMk4 FwMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751486074; x=1752090874; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=giyunrX2+D6X+A6e6UeKZhe7Cg6ipMHEWvo2VSb9DY0=; b=oYiciG7/fHqFX+BuhJ6tGwe6Kf5fAKi95X4lHZyD2i85bbp48dzF7jkHbyXIghGBmb +BeeQCDPUnXN6fUIYK8xhud+3lZfW7HNlTiAnV/+8/bl0lAa/OY2KvVHBUMGGNefHzTw oWtMeoSQIVKjCMOiH9f3OBDGo2pQaYsPoVtkCgZJTaO/JYSnUnEFC0vB5HercOl8MC/q jMot7k2U6i2EMZyeDv6QRH7mgN8j+n5aqf5vAEgAqsdsNX9Q7VeQ0Bj7ekIoontGHG9Q IbTTTO+ynjW9244FTrD3QdCKsQ5LTW0K3hMckOTehO+HLm92suATAK9/k7ABBd9bLgbX q+fQ== X-Forwarded-Encrypted: i=1; AJvYcCWk9eZHKtOsurIGt3EEMZz6fTBYKa+4ASce+hPpN/2mJz3p8oHwNN6fNn2yAnWeLG7o2aZi0IIH1W0c6GE=@vger.kernel.org X-Gm-Message-State: AOJu0Yyx+s4UHtoS5gDeaIZGeKVYvONWsOOTzyto8UQz6qr26nWL5rfI tIleYyTliDvZA6ePvwm/xh1LtHKAY7WxRwICgWU08o5S+bEUkkpVaIr6idgybT7Rsw4= X-Gm-Gg: ASbGncskzWgXQF3me+DpyiBl7J6lChECl3uqeZpnfgfv1zIeNtreziZE5+6aiZusUQL 0+W4xrd7gI/OgtV+DldGzNkvZOgo724BprfnU0laXxLlIUiMbFdAp7tDl0+6DdYeD4BoYfTDfSs +Sxcqva5Ggr1TG8B5rsaGwsQewxGOsbsETERu8Mm+9O367Agpl8NYLNNZyyrqRbeq7STqdW6aZh wIH3l32T99fMvpgL63v2F9h1dO7X9vF8Uxk5HJHRHD5UHPDKoSq4nS73Rrcyf6Az2H7KA7RgXd5 nNdWAwtGN0Ax3lcU4BXqBsEHdIrFE+Bt9/KPPJwlJ45sBOgYgK0qf058cN+GkbRYFbBSrg== X-Google-Smtp-Source: AGHT+IFfXZBSnWI+uH/87ZyqSk3q7Ci+q/p9P0dxU0KgN0/eFw5XVndfUZwPsNbWV/HmbRCS/xowMQ== X-Received: by 2002:a05:6820:3093:b0:611:bbad:7ce1 with SMTP id 006d021491bc7-612011c000bmr3140143eaf.4.1751486074430; Wed, 02 Jul 2025 12:54:34 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:7056:ddb5:3445:864f]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-611b848d77fsm1793343eaf.14.2025.07.02.12.54.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jul 2025 12:54:33 -0700 (PDT) Date: Wed, 2 Jul 2025 22:54:32 +0300 From: Dan Carpenter To: "Bowman, Terry" Cc: Jonathan Cameron , dave@stgolabs.net, dave.jiang@intel.com, alison.schofield@intel.com, dan.j.williams@intel.com, bhelgaas@google.com, shiju.jose@huawei.com, ming.li@zohomail.com, Smita.KoralahalliChannabasappa@amd.com, rrichter@amd.com, PradeepVineshReddy.Kodamati@amd.com, lukas@wunner.de, Benjamin.Cheatham@amd.com, sathyanarayanan.kuppuswamy@linux.intel.com, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v10 05/17] CXL/AER: Introduce kfifo for forwarding CXL errors Message-ID: References: <20250626224252.1415009-1-terry.bowman@amd.com> <20250626224252.1415009-6-terry.bowman@amd.com> <20250627112429.00007155@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jul 02, 2025 at 11:21:20AM -0500, Bowman, Terry wrote: > > > On 6/27/2025 5:24 AM, Jonathan Cameron wrote: > > On Thu, 26 Jun 2025 17:42:40 -0500 > > Terry Bowman wrote: > > > >> CXL error handling will soon be moved from the AER driver into the CXL > >> driver. This requires a notification mechanism for the AER driver to share > >> the AER interrupt with the CXL driver. The notification will be used > >> as an indication for the CXL drivers to handle and log the CXL RAS errors. > >> > >> First, introduce cxl/core/native_ras.c to contain changes for the CXL > >> driver's RAS native handling. This as an alternative to dropping the > >> changes into existing cxl/core/ras.c file with purpose to avoid #ifdefs. > >> Introduce CXL Kconfig CXL_NATIVE_RAS, dependent on PCIEAER_CXL, to > >> conditionally compile the new file. > >> > >> Add a kfifo work queue to be used by the AER driver and CXL driver. The AER > >> driver will be the sole kfifo producer adding work and the cxl_core will be > >> the sole kfifo consumer removing work. Add the boilerplate kfifo support. > >> > >> Add CXL work queue handler registration functions in the AER driver. Export > >> the functions allowing CXL driver to access. Implement registration > >> functions for the CXL driver to assign or clear the work handler function. > >> > >> Introduce 'struct cxl_proto_err_info' to serve as the kfifo work data. This > >> will contain the erring device's PCI SBDF details used to rediscover the > >> device after the CXL driver dequeues the kfifo work. The device rediscovery > >> will be introduced along with the CXL handling in future patches. > >> > >> Signed-off-by: Terry Bowman > > Hi Terry, > > > > Whilst it obviously makes patch preparation a bit more time consuming > > for series like this with many patches it can be useful to add a brief > > change log to the individual patches as well as the cover letter. > > That helps reviewers figure out where they need to look again. > > > > A few trivial things inline. > > > > With those fixed up > > Reviewed-by: Jonathan Cameron > > > > Jonathan > > Hi Jonathan, > > Do you have an example you can point me to with a change log in the > individual patch? I want to make certain I change correctly. > https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ Just put a: --- v2: white space changes or whatever. regards, dan carpenter