From: Hans de Goede <hdegoede@redhat.com>
To: Kenny Levinsen <kl@kl.wtf>, Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Douglas Anderson <dianders@chromium.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] HID: i2c-hid: Revert to await reset ACK before reading report descriptor
Date: Tue, 2 Apr 2024 13:43:33 +0200 [thread overview]
Message-ID: <c5ee5eec-b00e-41b3-bbef-6f0d58d70d66@redhat.com> (raw)
In-Reply-To: <cae66cad-e49a-4fa7-83cc-70aaf3346419@kl.wtf>
Hi,
On 4/2/24 1:30 PM, Kenny Levinsen wrote:
> On 4/2/24 1:06 PM, Hans de Goede wrote:
>> One small remark comment below. In the hope of getting this merged
>> soon I'll prepare a v3 addressing this myself (keeping you as the author).
>
>
> A-OK from my side, the abort_reset label is indeed redundant now.
>
> (The split between start and finish is also technically redundant when we always finish after start, but I wanted to keep the change minimal.)
Right actually for undoing the moving of the finish-reset
you could also have done a straight forward revert:
git revert af93a167eda9
My v3 is pretty close to this, but not exactly a full revert
since I kept your minimal approach.
Undoing the split however does not cleanly revert.
Regards,
Hans
next prev parent reply other threads:[~2024-04-02 11:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-31 18:24 Kenny Levinsen
2024-04-02 11:06 ` Hans de Goede
2024-04-02 11:30 ` Kenny Levinsen
2024-04-02 11:43 ` Hans de Goede [this message]
2024-04-22 17:10 ` Linux regression tracking (Thorsten Leemhuis)
2024-04-23 14:59 ` Benjamin Tissoires
2024-04-24 16:56 ` regression fixes sitting in subsystem git trees for a week or longer (was: Re: [PATCH v2] HID: i2c-hid: Revert to await reset ACK before reading report descriptor) Thorsten Leemhuis
2024-04-24 18:53 ` Linus Torvalds
2024-04-25 8:25 ` regression fixes sitting in subsystem git trees for a week or longer Thorsten Leemhuis
2024-04-25 8:44 ` Benjamin Tissoires
2024-04-25 9:33 ` Linux regression tracking (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5ee5eec-b00e-41b3-bbef-6f0d58d70d66@redhat.com \
--to=hdegoede@redhat.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dianders@chromium.org \
--cc=jikos@kernel.org \
--cc=kl@kl.wtf \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®