From: "Cédric Le Goater" <clg@kaod.org>
To: Joel Stanley <joel@jms.id.au>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Arnd Bergmann <arnd@arndb.de>, Andrew Jeffery <andrew@aj.id.au>,
Patrick Venture <venture@google.com>, Xo Wang <xow@google.com>,
Lei YU <mine260309@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Jeremy Kerr <jk@ozlabs.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org
Subject: Re: [PATCH v2 10/19] ARM: dts: aspeed: Add LPC Snoop device
Date: Mon, 18 Dec 2017 10:16:19 +0100 [thread overview]
Message-ID: <c5ef27de-34c1-f5e9-e4ae-e2709b004677@kaod.org> (raw)
In-Reply-To: <20171215062443.23059-11-joel@jms.id.au>
On 12/15/2017 07:24 AM, Joel Stanley wrote:
> LPC snoop hardware on the ASPEED BMC, used for monitoring
> host I/O port activity.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> arch/arm/boot/dts/aspeed-g4.dtsi | 7 +++++++
> arch/arm/boot/dts/aspeed-g5.dtsi | 6 ++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
> index f6fee40c04c0..b3580f37f507 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -236,6 +236,13 @@
> status = "disabled";
> };
>
> + lpc_snoop: lpc-snoop@0 {
> + compatible = "aspeed,ast2500-lpc-snoop";
it should be :
aspeed,ast2400-lpc-snoop
a part from that :
Reviewed-by: Cédric Le Goater <clg@kaod.org>
> + reg = <0x0 0x80>;
> + interrupts = <8>;
> + status = "disabled";
> + };
> +
> lhc: lhc@20 {
> compatible = "aspeed,ast2500-lhc";
> reg = <0x20 0x24 0x48 0x8>;
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index 96a9d2fe3f0d..50766f0629f8 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -287,6 +287,12 @@
> status = "disabled";
> };
>
> + lpc_snoop: lpc-snoop@0 {
> + compatible = "aspeed,ast2500-lpc-snoop";
> + reg = <0x0 0x80>;
> + interrupts = <8>;
> + status = "disabled";
> + };
>
> lhc: lhc@20 {
> compatible = "aspeed,ast2500-lhc";
>
next prev parent reply other threads:[~2017-12-18 9:16 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 6:24 [PATCH v2 00/19] ARM: dts: aspeed: updates and new machines Joel Stanley
2017-12-15 6:24 ` [PATCH v2 01/19] dt-bindings: clock: Add ASPEED constants Joel Stanley
2017-12-16 18:09 ` Rob Herring
2017-12-15 6:24 ` [PATCH v2 02/19] dt-bindings: gpio: " Joel Stanley
2017-12-16 18:17 ` Rob Herring
2017-12-15 6:24 ` [PATCH v2 03/19] ARM: dts: aspeed: Add LPC and child devices Joel Stanley
2017-12-18 9:25 ` Cédric Le Goater
2017-12-20 3:21 ` Joel Stanley
2017-12-15 6:24 ` [PATCH v2 04/19] ARM: dts: aspeed: Add proper clock references Joel Stanley
2017-12-15 6:24 ` [PATCH v2 05/19] ARM: dts: aspeed: Add MAC clocks Joel Stanley
2017-12-15 6:24 ` [PATCH v2 06/19] ARM: dts: aspeed: Add watchdog clocks Joel Stanley
2017-12-18 9:02 ` Cédric Le Goater
2017-12-15 6:24 ` [PATCH v2 07/19] ARM: dts: aspeed: Add flash controller clocks Joel Stanley
2017-12-18 9:03 ` Cédric Le Goater
2017-12-15 6:24 ` [PATCH v2 08/19] ARM: dts: aspeed: Add clock phandle to GPIO Joel Stanley
2017-12-15 6:24 ` [PATCH v2 09/19] ARM: dts: aspeed: Add PWM and tachometer node Joel Stanley
2017-12-15 6:24 ` [PATCH v2 10/19] ARM: dts: aspeed: Add LPC Snoop device Joel Stanley
2017-12-18 9:16 ` Cédric Le Goater [this message]
2017-12-20 3:21 ` Joel Stanley
2017-12-15 6:24 ` [PATCH v2 11/19] ARM: dts: aspeed: Remove skeleton.dtsi Joel Stanley
2017-12-18 9:08 ` Cédric Le Goater
2017-12-15 6:24 ` [PATCH v2 12/19] ARM: dts: aspeed: Update license headers Joel Stanley
2017-12-18 9:05 ` Cédric Le Goater
2017-12-15 6:24 ` [PATCH v2 13/19] ARM: dts: Add OpenBMC flash layout Joel Stanley
2017-12-18 9:04 ` Cédric Le Goater
2017-12-15 6:24 ` [PATCH v2 14/19] ARM: dts: aspeed: Sort ASPEED entries in makefile Joel Stanley
2017-12-18 9:06 ` Cédric Le Goater
2017-12-15 6:24 ` [PATCH v2 15/19] ARM: dts: aspeed: Add Witherspoon BMC machine Joel Stanley
2017-12-15 6:24 ` [PATCH v2 16/19] ARM: dts: aspeed: Add Ingrasys Zaius " Joel Stanley
2017-12-15 6:24 ` [PATCH v2 17/19] ARM: dts: aspeed: Add Qanta Q71L " Joel Stanley
2017-12-15 6:24 ` [PATCH v2 18/19] ARM: dts: aspeed-romulus: Update Romulus system Joel Stanley
2017-12-18 9:32 ` Cédric Le Goater
2017-12-20 3:22 ` Joel Stanley
2017-12-15 6:24 ` [PATCH v2 19/19] ARM: dts: aspeed-plametto: Add flash layout Joel Stanley
2017-12-18 9:09 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5ef27de-34c1-f5e9-e4ae-e2709b004677@kaod.org \
--to=clg@kaod.org \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mine260309@gmail.com \
--cc=robh+dt@kernel.org \
--cc=venture@google.com \
--cc=xow@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®