mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Cosmin Tanislav <demonsingur@gmail.com>
Cc: cosmin.tanislav@analog.com, Jean Delvare <jdelvare@suse.com>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/8] hwmon: (adt7410) Pass name to core driver
Date: Tue, 21 Dec 2021 12:47:17 -0800	[thread overview]
Message-ID: <c5effd54-df4d-c7aa-47a2-f7fdcee5354a@roeck-us.net> (raw)
In-Reply-To: <20211221201113.752827-1-demonsingur@gmail.com>

On 12/21/21 12:11 PM, Cosmin Tanislav wrote:
> From: Cosmin Tanislav <cosmin.tanislav@analog.com>
> 
> It will later be used to register hwmon device using
> hwmon_device_register_with_info.
> 
> Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com>
> ---
>   drivers/hwmon/adt7410.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/adt7410.c b/drivers/hwmon/adt7410.c
> index 973db057427b..ef4b5af865e9 100644
> --- a/drivers/hwmon/adt7410.c
> +++ b/drivers/hwmon/adt7410.c
> @@ -45,7 +45,7 @@ static int adt7410_i2c_probe(struct i2c_client *client)
>   			I2C_FUNC_SMBUS_BYTE_DATA | I2C_FUNC_SMBUS_WORD_DATA))
>   		return -ENODEV;
>   
> -	return adt7x10_probe(&client->dev, NULL, client->irq, &adt7410_i2c_ops);
> +	return adt7x10_probe(&client->dev, client->name, client->irq, &adt7410_i2c_ops);
>   }
>   
>   static int adt7410_i2c_remove(struct i2c_client *client)
> 

This series looks very similar to the previous series, yet there is
no change log, and it again claims to be v1 of a patch series. Either
explain why this series is so different to the similar looking patch
series starting with "hwmon: adt7x10: store bus_dev in private data",
that it doesn't deserve to be called v2, or provide change logs and
version your series.

If you expect me to figure out what changed, sorry, that is not how
it works. I won't even look at this series.

Guenter

  parent reply	other threads:[~2021-12-21 20:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-21 20:11 Cosmin Tanislav
2021-12-21 20:11 ` [PATCH v1 2/8] hwmon: (adt7x10) Store bus_dev in private data Cosmin Tanislav
2021-12-21 20:11 ` [PATCH v1 3/8] hwmon: (adt7x10) Add device managed action for restoring config Cosmin Tanislav
2021-12-21 20:11 ` [PATCH v1 4/8] hwmon: (adt7x10) Use devm_hwmon_device_register_with_info Cosmin Tanislav
2021-12-21 20:11 ` [PATCH v1 5/8] hwmon: (adt7x10) Use devm_request_threaded_irq Cosmin Tanislav
2021-12-21 20:11 ` [PATCH v1 6/8] hwmon: (adt7x10) Remove empty driver removal callback Cosmin Tanislav
2021-12-21 20:11 ` [PATCH v1 7/8] hwmon: (adt7x10) Pass hwinfo dev to irq handler Cosmin Tanislav
2021-12-21 20:11 ` [PATCH v1 8/8] hwmon: (adt7x10) Use hwmon_notify_event Cosmin Tanislav
2021-12-21 20:47 ` Guenter Roeck [this message]
2021-12-21 20:58   ` [PATCH v1 1/8] hwmon: (adt7410) Pass name to core driver Cosmin Tanislav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5effd54-df4d-c7aa-47a2-f7fdcee5354a@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=cosmin.tanislav@analog.com \
    --cc=demonsingur@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®