From: yannick Fertre <yannick.fertre@foss.st.com>
To: "José Expósito" <jose.exposito89@gmail.com>, contact@emersion.fr
Cc: <dmitry.baryshkov@linaro.org>,
<maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
<tzimmermann@suse.de>, <airlied@linux.ie>, <daniel@ffwll.ch>,
<jani.nikula@linux.intel.com>, <joonas.lahtinen@linux.intel.com>,
<rodrigo.vivi@intel.com>, <marex@denx.de>, <stefan@agner.ch>,
<shawnguo@kernel.org>, <s.hauer@pengutronix.de>,
<kernel@pengutronix.de>, <festevam@gmail.com>,
<linux-imx@nxp.com>, <philippe.cornu@foss.st.com>,
<benjamin.gaignard@linaro.org>, <mcoquelin.stm32@gmail.com>,
<alexandre.torgue@foss.st.com>, <dri-devel@lists.freedesktop.org>,
<linux-kernel@vger.kernel.org>, <intel-gfx@lists.freedesktop.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH v2 6/6] drm/stm: ltdc: Drop format_mod_supported function
Date: Wed, 12 Jan 2022 10:44:26 +0100 [thread overview]
Message-ID: <c5ffa201-4811-b070-75b5-85064cd78506@foss.st.com> (raw)
In-Reply-To: <20211222090552.25972-7-jose.exposito89@gmail.com>
Hello José,
thanks for your patch.
Reviewed-by: Yannick Fertre <yannick.fertre@foss.st.com>
Tested-by: Yannick Fertre <yannick.fertre@foss.st.com>
On 12/22/21 10:05 AM, José Expósito wrote:
> The "drm_plane_funcs.format_mod_supported" can be removed in favor of
> the default implementation.
>
> Signed-off-by: José Expósito <jose.exposito89@gmail.com>
> ---
> drivers/gpu/drm/stm/ltdc.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index dbdee954692a..ef909e50f0e4 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -925,16 +925,6 @@ static void ltdc_plane_atomic_print_state(struct drm_printer *p,
> fpsi->counter = 0;
> }
>
> -static bool ltdc_plane_format_mod_supported(struct drm_plane *plane,
> - u32 format,
> - u64 modifier)
> -{
> - if (modifier == DRM_FORMAT_MOD_LINEAR)
> - return true;
> -
> - return false;
> -}
> -
> static const struct drm_plane_funcs ltdc_plane_funcs = {
> .update_plane = drm_atomic_helper_update_plane,
> .disable_plane = drm_atomic_helper_disable_plane,
> @@ -943,7 +933,6 @@ static const struct drm_plane_funcs ltdc_plane_funcs = {
> .atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
> .atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
> .atomic_print_state = ltdc_plane_atomic_print_state,
> - .format_mod_supported = ltdc_plane_format_mod_supported,
> };
>
> static const struct drm_plane_helper_funcs ltdc_plane_helper_funcs = {
>
next prev parent reply other threads:[~2022-01-12 9:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 9:05 [PATCH v2 0/6] Add missing format_mod_supported functions José Expósito
2021-12-22 9:05 ` [PATCH v2 1/6] drm/plane: Make format_mod_supported truly optional José Expósito
2021-12-23 10:10 ` Simon Ser
2021-12-23 11:56 ` Ville Syrjälä
2021-12-23 13:42 ` Simon Ser
2021-12-23 15:03 ` Ville Syrjälä
2021-12-23 16:57 ` José Expósito
2021-12-22 9:05 ` [PATCH v2 2/6] drm/plane: Fix typo in format_mod_supported documentation José Expósito
2021-12-23 10:07 ` Simon Ser
2021-12-22 9:05 ` [PATCH v2 3/6] drm/simple-kms: Drop format_mod_supported function José Expósito
2021-12-22 9:05 ` [PATCH v2 4/6] drm/i915/display: " José Expósito
2021-12-22 9:05 ` [PATCH v2 5/6] drm: mxsfb: " José Expósito
2021-12-22 9:05 ` [PATCH v2 6/6] drm/stm: ltdc: " José Expósito
2022-01-12 9:44 ` yannick Fertre [this message]
2022-01-12 10:01 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5ffa201-4811-b070-75b5-85064cd78506@foss.st.com \
--to=yannick.fertre@foss.st.com \
--cc=airlied@linux.ie \
--cc=alexandre.torgue@foss.st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=contact@emersion.fr \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=jose.exposito89@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marex@denx.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=mripard@kernel.org \
--cc=philippe.cornu@foss.st.com \
--cc=rodrigo.vivi@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®