From: Dave Hansen <dave.hansen@intel.com>
To: Eric Dumazet <edumazet@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
netdev@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH] x86_64: inline csum_ipv6_magic()
Date: Thu, 13 Nov 2025 08:26:14 -0800 [thread overview]
Message-ID: <c6020af6-83d0-46c9-aad9-2187b7f07cbe@intel.com> (raw)
In-Reply-To: <20251113154545.594580-1-edumazet@google.com>
On 11/13/25 07:45, Eric Dumazet wrote:
> Inline this small helper.
>
> This reduces register pressure, as saddr and daddr are often
> back to back in memory.
>
> For instance code inlined in tcp6_gro_receive() will look like:
Could you please double check what the code growth is for this across
the tree? There are 80-ish users of csum_ipv6_magic().
Or, is there a discrete, measurable performance gain from doing this?
next prev parent reply other threads:[~2025-11-13 16:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 15:45 Eric Dumazet
2025-11-13 16:26 ` Dave Hansen [this message]
2025-11-13 18:18 ` Eric Dumazet
2025-11-13 18:40 ` Dave Hansen
2025-12-23 5:03 ` Eric Dumazet
2025-11-13 20:03 ` David Laight
2025-11-13 20:12 ` Eric Dumazet
2026-01-05 18:51 ` [tip: x86/misc] x86/lib: Inline csum_ipv6_magic() tip-bot2 for Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6020af6-83d0-46c9-aad9-2187b7f07cbe@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=hpa@zytor.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®