From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932480AbcH1Sbb (ORCPT ); Sun, 28 Aug 2016 14:31:31 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34720 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751367AbcH1Sb3 (ORCPT ); Sun, 28 Aug 2016 14:31:29 -0400 Subject: Re: [PATCH 1/1] ASoC: Intel: Atom: add a missing star in a memcpy call To: Joe Perches , Liam Girdwood , Mark Brown , alsa-devel@alsa-project.org References: <20160828173945.27721-1-nicolas.iooss_linux@m4x.org> <1472408231.26978.98.camel@perches.com> Cc: linux-kernel@vger.kernel.org From: Nicolas Iooss Message-ID: Date: Sun, 28 Aug 2016 20:31:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1472408231.26978.98.camel@perches.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/08/16 20:17, Joe Perches wrote: > On Sun, 2016-08-28 at 19:39 +0200, Nicolas Iooss wrote: >> In sst_prepare_and_post_msg(), when a response is received in "block", >> the following code gets executed: >> >> *data = kzalloc(block->size, GFP_KERNEL); >> memcpy(data, (void *) block->data, block->size); >> >> The memcpy() call overwrites the content of the *data pointer instead of >> filling the newly-allocated memory (which pointer is hold by *data). >> Fix this by using *data in the memcpy() call. >> >> Fixes: 60dc8dbacb00 ("ASoC: Intel: sst: Add some helper functions") >> Cc: stable@vger.kernel.org # 3.19.x >> Signed-off-by: Nicolas Iooss >> --- >> sound/soc/intel/atom/sst/sst_pvt.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sound/soc/intel/atom/sst/sst_pvt.c b/sound/soc/intel/atom/sst/sst_pvt.c >> index adb32fefd693..7c398b7c9d4b 100644 >> --- a/sound/soc/intel/atom/sst/sst_pvt.c >> +++ b/sound/soc/intel/atom/sst/sst_pvt.c >> @@ -289,7 +289,7 @@ int sst_prepare_and_post_msg(struct intel_sst_drv *sst, >> ret = -ENOMEM; >> goto out; >> } else >> - memcpy(data, (void *) block->data, block->size); >> + memcpy(*data, (void *) block->data, block->size); >> } >> } >> out: > > Perhaps this would be nicer using kmemdup too Thanks for your quick reply! I agree using kmemdup looks nicer here and your patch looks good. I will send a v2 once I compile-tested it. Nicolas