Re: [PATCH v11 0/6] Display enablement changes for Qualcomm QCS8300 platform

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 9/4/25 11:31 AM, Yongxing Mou wrote:
> 
> 
> On 9/4/2025 4:21 PM, Konrad Dybcio wrote:
>> On 9/4/25 9:55 AM, Yongxing Mou wrote:
>>>
>>>
>>> On 9/4/2025 3:22 PM, Yongxing Mou wrote:
>>>> This series introduces support to enable the Mobile Display Subsystem (MDSS)
>>>> , Display Processing Unit (DPU), DisplayPort controller for the Qualcomm
>>>> QCS8300 target. It includes the addition of the hardware catalog, compatible
>>>> string, and their YAML bindings.
>>>>
>>>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
>>>> ---
>>>> Changes in v11: Fixed review comments from Dmitry.
>>>> - Rebase to MST bindings V8.
>>>> - Update the clocks-name for QCS8300 in dp-controller.
>>>> - Link to v10: https://lore.kernel.org/r/20250901-qcs8300_mdss-v10-0-87cab7e48479@oss.qualcomm.com
>>>>
>>>> Changes in v10:
>>>> - Rebase to MST bindings V7.
>>>> - Update the P2/P3/MST2LINK/MST3LINK regions in MDSS yaml.
>>>> - Link to v9: https://lore.kernel.org/r/20250825-qcs8300_mdss-v9-0-ebda1de80ca0@oss.qualcomm.com
>>>>
>>>> Changes in v9: Fixed review comments from Dmitry.
>>>> - Updated the description of dp-controller DT binding.
>>>> - Add new clause only work for QCS8300(one DP controller with 4 streams).
>>>> - Link to v8: https://lore.kernel.org/r/20250821-qcs8300_mdss-v8-0-e9be853938f9@oss.qualcomm.com
>>>>
>>>> Changes in v8: Fixed review comments from Krzysztof, Dmitry.
>>>> - Fixed incorrect description for dp-controller in driver/dt-binding.[Krzysztof][Dmitry]
>>>> - Fixed incorrect description for ubwc change.[Dmitry]
>>>> - Link to v7: https://lore.kernel.org/r/20250819-qcs8300_mdss-v7-0-49775ef134f4@oss.qualcomm.com
>>>>
>>>> Changes in v7: Fixed review comments from Dmitry.
>>>> - Rebase to next-20250818 and 4 pixel stream series V6.
>>>> - Add more description for the dp-controller dt-bingding change.[Dmitry]
>>>> - Reorder the MDSS change and UBWC change.[Dmitry]
>>>> - Switch to the OSS email.
>>>> - Link to v6: https://lore.kernel.org/r/20250806-mdssdt_qcs8300-v6-0-dbc17a8b86af@quicinc.com
>>>>
>>>> Changes in v6: Fixed review comments from Konrad, Dmitry.
>>>> - Rewrite commit msg in dp-controller dt-binding change.[Dmitry]
>>>> - Optimize the description in MDSS dt-binding.[Dmitry]
>>>> - Pass the sc8280xp_data as fallback in the UBWC change.[Konrad]
>>>> - Add the DP controller driver change.
>>>> - Link to v5: https://lore.kernel.org/r/20250730-mdssdt_qcs8300-v5-0-bc8ea35bbed6@quicinc.com
>>>>
>>>> Changes in v5:Fixed review comments from Krzysztof, Dmitry.
>>>> - Rebase to next-20250717.
>>>> - Change DP compatible to qcs8300-dp due to add 4 streams support.
>>>> - Add QCS8300 UBWC config change due to rebase.
>>>> - Add 4 streams clk and phy in the mdss yaml.
>>>> - Link to v4: https://lore.kernel.org/r/20250120-mdssdt_qcs8300-v4-0-1687e7842125@quicinc.com
>>>>
>>>> Changes in v4:Fixed review comments from Krzysztof, Dmitry.
>>>> - Use the common style for the dt-bindings commits.[Dmitry]
>>>> - Update the commits msg for the mdss binding patch, explain why they
>>>>     reuse different platform drivers.[Krzysztof]
>>>> - Link to v3: https://lore.kernel.org/r/20250113-mdssdt_qcs8300-v3-0-6c8e93459600@quicinc.com
>>>>
>>>> Changes in v3:Fixed review comments from Krzysztof, Dmitry.
>>>> - Fix the missing space issue in commit message.[Krzysztof]
>>>> - Separate the patch for the phy from this series.[Dmitry]
>>>> - Remove unused dependencies and update in the cover letter.[Dmitry][Krzysztof]
>>>> - Link to v2: https://lore.kernel.org/r/20241226-mdssdt_qcs8300-v2-0-acba0db533ce@quicinc.com
>>>>
>>>> Changes in v2:Fixed review comments from Krzysztof, Dmitry, Rob.
>>>> - Decouple the devicetree changes from this series.[Dmitry][Krzysztof]
>>>> - Drop the dpu driver changes and reuse SA8775P DPU driver.[Dmitry]
>>>> - Fix compilation issues in MDSS bindings.[Rob][Krzysztof]
>>>> - Correct formatting errors and remove unnecessary status in MDSS
>>>>     bindings.[Krzysztof]
>>>> - Add the the necessary information in MDSS changes commit msg.[Dmitry]
>>>> - Rebase MDSS driver changes to https://lore.kernel.org/dri-devel/
>>>>     20241127-msm-mdss-ubwc-v3-0-9782a7c2b023@linaro.org/.[Dmitry]
>>>> - Package the DisplayPort controller and eDP PHY bindings document to
>>>>     this patch series.
>>>> - Collecting MDSS changes reviewd-by Dmitry.
>>>> - Reuse the sa8775p eDP PHY as a fallback compat.[Dmitry]
>>>> - Reuse the sm8650 DP controller as a fallback compat.[Dmitry]
>>>> - Link to v1: https://lore.kernel.org/r/20241127-mdss_qcs8300-v1-0-29b2c3ee95b8@quicinc.com
>>>> ---
>>>> This series depend on 4 pixel streams dt-binding series:
>>>> https://lore.kernel.org/all/20250903-dp_mst_bindings-v8-0-7526f0311eaa@oss.qualcomm.com/
>>>>
>>>> and separate eDP PHY binding:
>>>> https://lore.kernel.org/all/20250730072725.1433360-1-quic_yongmou@quicinc.com/
>>>>
>>>> ---
>>>> Yongxing Mou (6):
>>>>         dt-bindings: display/msm: Document the DPU for QCS8300
>>>>         dt-bindings: display/msm: dp-controller: document QCS8300 compatible
>>>>         dt-bindings: display/msm: Document MDSS on QCS8300
>>>>         soc: qcom: ubwc: Add QCS8300 UBWC cfg
>>>>         drm/msm: mdss: Add QCS8300 support
>>>>         drm/msm/dp: Add DisplayPort controller for QCS8300
>>>>
>>>>    .../bindings/display/msm/dp-controller.yaml        |  22 ++
>>>>    .../bindings/display/msm/qcom,qcs8300-mdss.yaml    | 286 +++++++++++++++++++++
>>>>    .../bindings/display/msm/qcom,sm8650-dpu.yaml      |  15 +-
>>>>    drivers/gpu/drm/msm/dp/dp_display.c                |   1 +
>>>>    drivers/gpu/drm/msm/msm_mdss.c                     |   1 +
>>>>    drivers/soc/qcom/ubwc_config.c                     |   1 +
>>>>    6 files changed, 321 insertions(+), 5 deletions(-)
>>>> ---
>>>> base-commit: 3ac864c2d9bb8608ee236e89bf561811613abfce
>>>> change-id: 20250818-qcs8300_mdss-a363f0d0ba0b
>>>> prerequisite-message-id: <20250903-dp_mst_bindings-v8-0-7526f0311eaa@oss.qualcomm.com>
>>>> prerequisite-patch-id: ffeeb0739a4b3d310912f4bb6c0bd17802818879
>>>> prerequisite-patch-id: cdc3f4515ab23a8b2ce719bbdbcb56043803d03f
>>>> prerequisite-patch-id: 048b11765f49af4a728db1525fef1eb8ad48bf88
>>>> prerequisite-patch-id: f0f92109d1bfffa6a1142f2aaecbd72a29b858c0
>>>> prerequisite-patch-id: a8185cf3ddd85b9058691500b8dc0c57c8226e97
>>>> prerequisite-patch-id: a389a2e4eca44bf62bb2c861c96596368be7a021
>>>> prerequisite-patch-id: 09ec7f51de0a65c68c2c781750177017f32747ba
>>>> prerequisite-patch-id: f76ab0ae189df14acc851fa52f8f8e8faed9a505
>>>> prerequisite-patch-id: 983fc8a7bea459505c5b27db1a1ef7581936555c
>>>> prerequisite-message-id: <20250730072725.1433360-1-quic_yongmou@quicinc.com>
>>>> prerequisite-patch-id: 2ea89bba3c9c6ba37250ebd947c1d4acedc78a5d
>>>>
>>>> Best regards,
>>>
>>> Hi, maintainers:
>>> sorry for the inconvenience caused. This series is missing patch 5 and patch 6 due to network issues. May I resend it? The missed two changes are identical to V10.
>>
>> You can fix that manually by sending them both through
>>
>> b4 send -o /tmp/
>> git send-email --in-reply-to=<cover letter msgid> /tmp/0005-xyz-abc.patch
>> git send-email --in-reply-to=<cover letter msgid> /tmp/0006-xyz-abc.patch
>>
>> Konrad
> Thanks for guide, when i use cmd  "git send-email --in-reply-to="20250904-qcs8300_mdss-v11-0-bc8761964d76@oss.qualcomm.com" ~/tmpyongmou/0005-drm-msm-mdss-add-qcs8300-support.eml", seems something wrong, error log:
> mou@oss.qualcomm.com>,  Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>'
> (body) Adding cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> from line 'Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>'
> 5.1.3 The recipient address <y> is not a valid RFC 5321 address. For more
> 5.1.3 information, go to
> 5.1.3  https://support.google.com/a/answer/3221692 and review RFC 5321
> 5.1.3 specifications. d9443c01a7336-24b1ba1718bsm64512315ad.39 - gsmtpWould you mind sharing some suggestions for this? Thanks~~

Looks wrong, perhaps you pressed 'y' instinctively when git send-email asked you
whom (additionally) send the message to. Just to make sure b4 isn't broken I
tried something similar (ignore dry-run, I simply didn't want to send any emails): 

git send-email --dry-run /tmp/0014-illustrative_test.eml
To whom should the emails be sent (if anyone)? <enter>
Message-ID to be used as In-Reply-To for the first email (if any)? <enter>
<lots of email spam>

Result: OK