From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA446337BA1 for ; Fri, 19 Dec 2025 12:10:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766146207; cv=none; b=hOS49GUItMHD/Ee9EjlAJGKdj+F6e5uUczyfYe8ilEgyHAJNeGpj2s+URr0griQEZpv/tdEGibhIYcGATmUoA+akf8mtBjYhW2xFoFfTLEI7P+M/qT4o0SIq0B98EX8cn7oIflg4YCpJFEW0w+bHIgIRUVezOAEkgQzUSyKlTbE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766146207; c=relaxed/simple; bh=gpIoOy78pMZoCIbEE4j3i20bLFIXxKeGpbtD2INIchw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Lc7S/ZBbPORvSPmEBf1kfNLwvFxxJAGbxYchk2xgtfTPhbTrN9OS2iXa7HEZyz8hDed1yCeMDqBfaFPPqf2c5SLAr4pLpbdw7MqeDd4hSG9FszGOpA6VDKJYGKp084d/E3yUCmkXFJxPrXEwf29X7yUpSIlnaB1nDV4dC12hxeE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ez6nQNFH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CmojiihD; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ez6nQNFH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CmojiihD" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BJBRBtt3939133 for ; Fri, 19 Dec 2025 12:10:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tUolEG07YuA8naiVLt7C1pto13E5WsEaNtMVembr75w=; b=ez6nQNFHtFElylYI CejLvYIDmesxKQNdLPRZrlOlIcLXgBTgBzymhItffriRO1rum38dJuyNDnlMVr5y dtwOYQ+5owUkXGrpp5lFoGvtcpJ8/qMaw+dcFPi41+DjMJtkFx/Kaj3wBY/o95xe 7+/GsOv82CxskzwruoTS89fZ0tF0LkJrKgFik3gl3j9k7tFGUa53V1ZjiYYaQNLi JoaqVNPjVvwpBikY5MqQm9c9IMvtzq1BY5TCFtqbpM3bwMQ4lUm8+D45nC86KFk3 euGqKCyNB2aCoEXTeXgKCEt/cUXsuJQiTwiVR3WnlTLlogkdw5LoVjjlX7yEJAn1 VSKLOw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4r2c2ka8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Dec 2025 12:10:05 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ed6ff3de05so43817781cf.3 for ; Fri, 19 Dec 2025 04:10:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766146204; x=1766751004; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=tUolEG07YuA8naiVLt7C1pto13E5WsEaNtMVembr75w=; b=CmojiihDAyV2kxE8GGGa8yniBubjYhp2HdwI0boYncnuS3JqswTmBhvrHU7wimoJC+ EYDQqI/xVWGK7C2B5qPAXE8YlNSUbOGmQqRjnZ6b/8e2aFXoeFj+9d9lZ6ynMeoRioJo GJzTotG+wZkbUJuVibbOLmQuif9iPmATtWaiS7Q430BPqaWPgLdUvxsKqhafWOjE27FL 8AFNxzI22dtVz+k2UN4I7l84juowtidKrlklPtk3V/QZ20ZeC4wJJdemmCYWCKaf+ILX pPDz/3vUG9UGe2bUSlrY0WNCg+pwEt7RBKzxI6tAfx2OEUUgD8a5KsINsN84UQXhBPWv Ho4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766146204; x=1766751004; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tUolEG07YuA8naiVLt7C1pto13E5WsEaNtMVembr75w=; b=P+/hSuqL2DzSeEX+YiABWIx+rV+n7PBPOVHjBV4xqhKf6E/nDBkr3AX6OG+t7a8vqg ib7iTLw2YAlxac4F8KZTt9scw4xtpH/UdfQe3QwZ0sVd+C6J1isXjSU6OKHiEGy2vLVp Uvboq5mWOsss0izCx+CuCkqF5EcRdA6YXNe6d9fdrM0bs3kDyH8AnwSP4zpd2BhzwtZO Wb/VQCZaBjFW5wCPMe0spHlq+z8BLZFXU7HSwM4t95h7H9y5D4ofHxoTpMhbs/exK2Wu R3QlJ92V2Pz9nPpdV2GQkzqZ2aFIFgngCRiCPDQ41Iby58k8amZw1VcqxG9+pJHnGgIA Vaag== X-Forwarded-Encrypted: i=1; AJvYcCUtafxz7lMJQWIOaga1NJymRAf9BN0P0uHWSM3Vp33k/hi8kY+w3aZ82BDDvr2G5NjDmTtVkes65F5mPdI=@vger.kernel.org X-Gm-Message-State: AOJu0YxuucRouZUlQScE+FIzQV6evO0cSx/O2EHps8EuJfAvtVwHwfZF zBjBhHkvNOCnfJswn9gDXshbV0LCNrGr1mPNLqB2F0h4Z3OWm2mmY6bwPKSgv/1/OJ1OzMNybkh wMaFBDH9D7/b2hfQC/lStLuDotUQ3BqYxCP8+Jqn5iEsheXqojQavedFOXkrIr24chzQ= X-Gm-Gg: AY/fxX6vcdTae9ymyheopX61RWwsZ4EjPONecAWPepwnLQ54U5srjIPLz9/ikVioEnu I/UukzkgOapuWb3/29gJUTtAAnmkOqQPx4w3e5tUaDITyJLsAYjYyN6Eo9a7F8KwQ/H0yLFrHGo CD+OB0RzYZsptdbtii4uO5ZP/e7Ps7mN2I/0hDfsPs5A4oGBa2bHzKJ+K98n/dcEd16MzY0t6B3 NISTiM5Wl16XU6Lijw34M7jhGsWbvPPTtFFsmYWLjz4wmxI8YmrnnQ3qyD/zUsx/KvKm4mvjb9M 2abCmKBFPqNGXmSyFbCEolNe6A+MUiW+HRv/9Z/6mDDqSmgUJIcmA/ASEJ4VXbgOaYh+178g+g9 LWt0LDEkTksJaaabZhQhTtGgeGfDW1dl+zmUzogB4NJ85urar9+Ay2KjZiEg8nYKJBMY+3tQ7 X-Received: by 2002:ac8:5745:0:b0:4ed:b363:2c2 with SMTP id d75a77b69052e-4f4abdba542mr36235251cf.62.1766146204028; Fri, 19 Dec 2025 04:10:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IFNHE8mUt1RqbOG36asJqPTyKdt2EDtPV/2sqLUBv01aNJ8HLkYsLaCnyAzQhCj8S9G+cl7ag== X-Received: by 2002:ac8:5745:0:b0:4ed:b363:2c2 with SMTP id d75a77b69052e-4f4abdba542mr36234831cf.62.1766146203623; Fri, 19 Dec 2025 04:10:03 -0800 (PST) Received: from [192.168.1.27] (83.31.98.88.ipv4.supernova.orange.pl. [83.31.98.88]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b90f53c16sm2024766a12.1.2025.12.19.04.10.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Dec 2025 04:10:03 -0800 (PST) Message-ID: Date: Fri, 19 Dec 2025 13:10:01 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] gpio: zynq: Simplify with of_device_get_match_data() To: Bartosz Golaszewski Cc: Linus Walleij , Joel Stanley , Andrew Jeffery , Eugeniy Paltsev , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org References: <20251219-gpio-of-match-v2-0-5c65cbb513ac@oss.qualcomm.com> <20251219-gpio-of-match-v2-3-5c65cbb513ac@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@oss.qualcomm.com; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTpLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQG9zcy5xdWFsY29tbS5jb20+wsGXBBMB CgBBFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmkknB4CGwMFCRaWdJoFCwkIBwICIgIGFQoJ CAsCBBYCAwECHgcCF4AACgkQG5NDfTtBYpuCRw/+J19mfHuaPt205FXRSpogs/WWdheqNZ2s i50LIK7OJmBQ8+17LTCOV8MYgFTDRdWdM5PF2OafmVd7CT/K4B3pPfacHATtOqQFHYeHrGPf 2+4QxUyHIfx+Wp4GixnqpbXc76nTDv+rX8EbAB7e+9X35oKSJf/YhLFjGOD1Nl/s1WwHTJtQ a2XSXZ2T9HXa+nKMQfaiQI4WoFXjSt+tsAFXAuq1SLarpct4h52z4Zk//ET6Xs0zCWXm9HEz v4WR/Q7sycHeCGwm2p4thRak/B7yDPFOlZAQNdwBsnCkoFE1qLXI8ZgoWNd4TlcjG9UJSwru s1WTQVprOBYdxPkvUOlaXYjDo2QsSaMilJioyJkrniJnc7sdzcfkwfdWSnC+2DbHd4wxrRtW kajTc7OnJEiM78U3/GfvXgxCwYV297yClzkUIWqVpY2HYLBgkI89ntnN95ePyTnLSQ8WIZJk ug0/WZfTmCxX0SMxfCYt36QwlWsImHpArS6xjTvUwUNTUYN6XxYZuYBmJQF9eLERK2z3KUeY 2Ku5ZTm5axvlraM0VhUn8yv7G5Pciv7oGXJxrA6k4P9CAvHYeJSTXYnrLr/Kabn+6rc0my/l RMq9GeEUL3LbIUadL78yAtpf7HpNavYkVureuFD8xK8HntEHySnf7s2L28+kDbnDi27WR5kn u/POwU0EVUNcNAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDy fv4dEKuCqeh0hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOG mLPRIBkXHqJYoHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6 H79LIsiYqf92H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4ar gt4e+jum3NwtyupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8 nO2N5OsFJOcd5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFF knCmLpowhct95ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz 7fMkcaZU+ok/+HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgN yxBZepj41oVqFPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMi p+12jgw4mGjy5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYC GwwWIQSb0H4ODFH41ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92 Vcmzn/jaEBcqyT48ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbTh LsSN1AuyP8wFKChC0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH 5lSCjhP4VXiGq5ngCxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpF c1D/9NV/zIWBG1NR1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzeP t/SvC0RhQXNjXKBB+lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60 RtThnhKc2kLIzd8GqyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7q VT41xdJ6KqQMNGQeV+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZ v+PKIVf+zFKuh0At/TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1q wom6QbU06ltbvJE2K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHp cwzYbmi/Et7T2+47PN9NZAOyb771QoVr8A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: sDWK1vqzaYGhZ2ivklmPjMuneQpKbNit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE5MDEwMCBTYWx0ZWRfX0traGeImcuKj 06pALnq6T1Wh3btN3OEMQXouCAGmrM3F67F3KJLNF7K/Y1gbg6UaN3wKuGAchd3tA9R16HcN0Dv SQ6sf3B7yU9fjowl41B9Y1/lNIW2/fwlrVNQUItZTqxgZ39vJ7VF6TH5g/eyCpGdA1yWT/I6aoh HZqSuz1az2e3hbfu4W+Kg5Qh7AeCSNL6tU6+KotGQdeIqaAFsy3wZIp0fJ20LobHpV3PwKSBKZ9 ktlyteozWvIb2lgfsjGfbUTpNNntKOuPxMd+bn0l2YJyw8DgWN0YvoTgUyQdsmKHdCMgCHhHMxP HTofuquav5FwEcs+I34CNvujNkY7irHwbFwbUgQM5ZFZ1i/NAj23B+seK1djxcd5IrNFlNPuklE DXb8t1s/GU4iIdPaF/83AUVh3yZPe4vg9eiwtcD2J2zmvNZKSR69d7xdrzm+Obpm2VuJkvQ6V2Q 8sS0f8E2rxoZZVDGN6w== X-Authority-Analysis: v=2.4 cv=feSgCkQF c=1 sm=1 tr=0 ts=6945409d cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=qe4J/qXhiWkb1JZGYKbLYA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=kcWgoHX1vMHs3kmCK-YA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: sDWK1vqzaYGhZ2ivklmPjMuneQpKbNit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-19_03,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512190100 On 19/12/2025 11:15, Bartosz Golaszewski wrote: > On Fri, Dec 19, 2025 at 11:12 AM Krzysztof Kozlowski > wrote: >> >> Driver's probe function matches against driver's of_device_id table, >> where each entry has non-NULL match data, so of_match_node() can be >> simplified with of_device_get_match_data(). >> >> Signed-off-by: Krzysztof Kozlowski >> --- > > I think there are some copy-paste leftovers in your commit messages. I just did not update the commit msg. > You're saying you're using of_ functions but you're really going for > the device_ ones. Also update error messages. And possibly use > dev_err_probe() too while at it? Sure > > Same elsewhere. > > Bart Best regards, Krzysztof