From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BEF6423A82 for ; Thu, 7 May 2026 15:37:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168234; cv=none; b=h1Dypa0KHkhhxRsysKanKc+tTdEby4Y3T21OQFPEbIQ8ldQbIsCzojGN4ITE0+sSIk/udY9G5nT1GE23p2CNKQWZu79GbgN7Vsq7kymi0ZbLw18AIjjG0ZDcDvse4vofpdPCo4H57zuQ7V3sR4lrj9+x1M7u+seGhjBVocBLzCM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168234; c=relaxed/simple; bh=DjjYHcmCcGzlMwAJDZ2QeO3T6813g71FP5kp9xx6RUQ=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=OUbn2yAFk8CcW3QaN9KZ47OonAKMOqRYUQ+GvaAweqsIlN2ppn9Pp2yym4hMrvoxFHVu9tO/bntnqgdbWeuBgX+P1/0GeWURCCXK6Ihlccj+Z48eKOqmKQWX9Y0cbD2EwvBAxkfciUdW2OdNrVJlwRPGEZCKXlkPdtByd1s048s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=E6PLvA/d; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="E6PLvA/d" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-448528f4e69so712272f8f.3 for ; Thu, 07 May 2026 08:37:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778168231; x=1778773031; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=M8S+Tg2Eja+tOTOC+LVq5hYqCOZm7RH/gZAoL5yYOEA=; b=E6PLvA/dk3LtucRQ9h+QyD22qkw2LEP7k5Q4oDxSFC1WxoHZyrPe9e6NHM4Jhoz2gr gpYdR9ynvNp0bsd8wT9WpEc05zMwV55UFCvSLmZuBUrJi9RfRaIiczRXSMdiwvNYTv3y RSEIAKAsFznUG0DzTmqQ2JMRQyrR8vpE0biyu1VM6XtfswmRkeIwTVyOKc9AQX9RBnhX 1IgAHZfULiff3NToSOP48ZbcfnHL+BLyI5cO8rMT+co/tc2oyz3ZYJh7RUlTKyLPV1Wf KGUEfWj4bNwOHedRUWCvvEku9ma4x6A7jdZMXUBd3qjgMZpMmQ7IcK/g4fO0UQ2Aoziw JkmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778168231; x=1778773031; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M8S+Tg2Eja+tOTOC+LVq5hYqCOZm7RH/gZAoL5yYOEA=; b=jv7hndiiveS7aCjVpXsFEPE91X3vDYqtFyaJr8zjTEEMO5llMAyeXHmPo02baZYyvf Mp56yrL4TraokaV1YmCZNo73WjRAvn0/V5jM1ppXmzyHbQjTtMzXmZfCpQjixc9+8983 KT7ZgHKTiaPEuIpO6/0no4MRsQBT+ITqEHxy9bNoFS2LBGTERNSf6zC8Dh2xe3ibhVLf qzcQ77tF4eLRL/0cWN3fpUdFyv2Hn+PThBS2nqzCn7TqJmRo1t955VoEIvnghhXWGBW6 Pq9d3UnBUnTyoIAJ3FSqbcApVyMM4UTRU01lUDNP7AZQ2TZ6aAu42iMqTHxDRFgowRfu fkzw== X-Forwarded-Encrypted: i=1; AFNElJ/Ud9I7ZMQF3DYDYs521a4nxCQy8qy5NQ0sETxyyV0E8oHJlq9O6IWZw1U5MZV6Tj5hCBGukTS8kKwFEFs=@vger.kernel.org X-Gm-Message-State: AOJu0Yxm4ebLOsKi8h1FZ6xSCnV4a181naByiMzXK+piMoGxDEqIxL7A l153lsuE7PRMH8hOvyNXyeS7wQSC2HuGxN8oQ0R7OKmQw32Ww4fIRgAhcFOi+2lCRVY= X-Gm-Gg: AeBDieugBPlt+MwWJh8kjwdtY1TgQNj1RNqrTSWMaXRaRewpjfvAeQQOHE/paWAkSqU g2gQ327usUZjQ9gLibzidv2cBR3ttu5tzcgL0WvV7a0mL9CQoBu3GcWALdG+A3PDLUQsOsRh23h o2jWhTuENkCSrtdzWJbVyw4UHGyBmiDg6jTWmt0XgnRkMnpghSfHGYoqxhpqHSC64rco2eQic6g l3ef2iNlLw0edmN7dcYAUe/zoSd7HhHOu7SC6UiYF2RG0dosn4aTDigyhtLvNytrSriBPw143rM DpIXIGp7dD4Q2jF7HRggBr4aSaYhTqeKnI0X/xT85XRNygmPhoxCNTK/+YrvCGaMrLCL7WQJnxc IiAiNBmrdmJnFqiMl3sGf5B8HK2fgXm2vuYXTq9zOidtCyiZlsQdM3rqGotNVzpxLpSARXk1414 S2T/C4e+WJ0wLuNNcuRshcoQtE7Ep/bCwWOkVblf54f+avxvjJlS5sbcJekVUBdcqnT9PyaL6iZ mkIggZH0NH3G7VUqw== X-Received: by 2002:a05:600c:6095:b0:485:39b2:a47c with SMTP id 5b1f17b1804b1-48e51f48352mr138387665e9.25.1778168231238; Thu, 07 May 2026 08:37:11 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:6762:47bb:1e06:ff70? ([2a01:e0a:106d:1080:6762:47bb:1e06:ff70]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e53116a9fsm63070005e9.8.2026.05.07.08.37.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 08:37:10 -0700 (PDT) Message-ID: Date: Thu, 7 May 2026 17:37:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 08/10] drm/panel/truly-nt35597: Use refcounted allocation in place of devm_kzalloc() To: Albert Esteve , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Michael Tretter , Michael Walle , Dario Binacchi Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260507-drm_panel_init_rm-v1-0-51f448c7c291@redhat.com> <20260507-drm_panel_init_rm-v1-8-51f448c7c291@redhat.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260507-drm_panel_init_rm-v1-8-51f448c7c291@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/7/26 13:53, Albert Esteve wrote: > Move to using the new API devm_drm_panel_alloc() to allocate the > panel. In the call to the new API, avoid using explicit type and use > __typeof() for more type safety. > > Signed-off-by: Albert Esteve > --- > drivers/gpu/drm/panel/panel-truly-nt35597.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-truly-nt35597.c b/drivers/gpu/drm/panel/panel-truly-nt35597.c > index d447db912a61e..f740b9257c09c 100644 > --- a/drivers/gpu/drm/panel/panel-truly-nt35597.c > +++ b/drivers/gpu/drm/panel/panel-truly-nt35597.c > @@ -476,8 +476,6 @@ static int truly_nt35597_panel_add(struct truly_nt35597 *ctx) > /* dual port */ > gpiod_set_value(ctx->mode_gpio, 0); > > - drm_panel_init(&ctx->panel, dev, &truly_nt35597_drm_funcs, > - DRM_MODE_CONNECTOR_DSI); > drm_panel_add(&ctx->panel); > > return 0; > @@ -523,10 +521,12 @@ static int truly_nt35597_probe(struct mipi_dsi_device *dsi) > .node = NULL, > }; > > - ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL); > + ctx = devm_drm_panel_alloc(dev, __typeof(*ctx), panel, > + &truly_nt35597_drm_funcs, > + DRM_MODE_CONNECTOR_DSI); > > - if (!ctx) > - return -ENOMEM; > + if (IS_ERR(ctx)) > + return PTR_ERR(ctx); > > /* > * This device represents itself as one with two input ports which are > Reviewed-by: Neil Armstrong Thanks, Neil