mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH v2] MIPS: Limit check_bugs32() to affected platform
Date: Fri, 10 Apr 2020 09:25:06 -0700	[thread overview]
Message-ID: <c60f62cb-62e8-be13-f551-c9a13abc7f94@gmail.com> (raw)
In-Reply-To: <1586488859-18715-1-git-send-email-yangtiezhu@loongson.cn>



On 4/9/2020 8:20 PM, Tiezhu Yang wrote:
> In the current code, check_bugs32() only handles MIPS32 CPU type CPU_34K,
> it is better to build and call it on the affected platform.
> 
> Move check_bugs32() to the new added 34k-bugs32.c to indicate the fact that
> the code is specific to the 34k CPU, and also add CONFIG_CPU_34K_BUGS32 to
> control whether or not check the bugs.
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>

This is not a whole lot of code, so moving this to a separate
translation unit seems a bit heavy handed, also file renames, albeit
tracked properly by git are always a challenge when doing back ports.
-- 
Florian

  parent reply	other threads:[~2020-04-10 16:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-10  3:20 Tiezhu Yang
2020-04-10  4:18 ` Jiaxun Yang
2020-04-10  8:36 ` Jiaxun Yang
2020-04-10 16:25 ` Florian Fainelli [this message]
2020-04-11  2:32   ` Tiezhu Yang
2020-04-14 17:32     ` Thomas Bogendoerfer
2020-04-15  1:48       ` Tiezhu Yang
2020-04-15  8:31         ` Thomas Bogendoerfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c60f62cb-62e8-be13-f551-c9a13abc7f94@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=lixuefeng@loongson.cn \
    --cc=tsbogend@alpha.franken.de \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®