From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753730AbcEXBwv (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 May 2016 21:52:51 -0400
Received: from lucky1.263xmail.com ([211.157.147.134]:52233 "EHLO
	lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751485AbcEXBwt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 May 2016 21:52:49 -0400
X-263anti-spam: KSV:0;
X-MAIL-GRAY: 1
X-MAIL-DELIVERY: 0
X-KSVirus-check: 0
X-ABS-CHECKED: 4
X-ADDR-CHECKED: 0
X-RL-SENDER: shawn.lin@rock-chips.com
X-FST-TO: devicetree@vger.kernel.org
X-SENDER-IP: 58.22.7.114
X-LOGIN-NAME: shawn.lin@rock-chips.com
X-UNIQUE-TAG: <de690d6ecf3f816341564cb4c8046ba5>
X-ATTACHMENT-NUM: 0
X-DNS-TYPE: 0
Subject: Re: [PATCH v5 4/5] mmc: debugfs: add HS400 enhanced strobe
 description
To: Doug Anderson <dianders@chromium.org>
References: <1463976789-29618-1-git-send-email-shawn.lin@rock-chips.com>
 <1463976844-29821-1-git-send-email-shawn.lin@rock-chips.com>
 <CAD=FV=WFQ4aG-LhB=s6KhdoHtAjuQnaW6duyzh1LUKAHdDXvTA@mail.gmail.com>
Cc: shawn.lin@rock-chips.com, Ulf Hansson <ulf.hansson@linaro.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Jaehoon Chung <jh80.chung@samsung.com>,
        Michal Simek <michal.simek@xilinx.com>, soren.brinkmann@xilinx.com,
        Rob Herring <robh+dt@kernel.org>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Brian Norris <briannorris@chromium.org>,
        Heiko Stuebner <heiko@sntech.de>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
From: Shawn Lin <shawn.lin@rock-chips.com>
Message-ID: <c6137b5e-c77e-bb54-cf0a-c23e7714dfb1@rock-chips.com>
Date: Tue, 24 May 2016 09:52:32 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.0
MIME-Version: 1.0
In-Reply-To: <CAD=FV=WFQ4aG-LhB=s6KhdoHtAjuQnaW6duyzh1LUKAHdDXvTA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

在 2016/5/24 4:56, Doug Anderson 写道:
> Shawn,
>
> On Sun, May 22, 2016 at 9:14 PM, Shawn Lin <shawn.lin@rock-chips.com> wrote:
>> We introduce HS400 with enhanced strobe function, so we need
>> to add it for debug show.
>>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>> ---
>>
>> Changes in v5: None
>> Changes in v4: None
>> Changes in v3: None
>> Changes in v2: None
>>
>>  drivers/mmc/core/debugfs.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c
>> index 9382a57..51d7c38 100644
>> --- a/drivers/mmc/core/debugfs.c
>> +++ b/drivers/mmc/core/debugfs.c
>> @@ -148,7 +148,9 @@ static int mmc_ios_show(struct seq_file *s, void *data)
>>                 str = "mmc HS200";
>>                 break;
>>         case MMC_TIMING_MMC_HS400:
>> -               str = "mmc HS400";
>> +               mmc_card_hs400es(host->card) ?
>> +                       (str = "mmc HS400 enhanced strobe") :
>> +                       (str = "mmc HS400");
>
> Not sure it's terribly important, but I've typically seen this as:
>
> str = mmc_card_hs400es(host->card) ?
>           "mmc HS400 enhanced strobe" : "mmc HS400";
>
> AKA: don't repeat the "str ="
>

Thanks for your review and test. I wanna wait for some more days
to see if there are any other comments for this patchset.


> I doubt it really matters that much, though, so:
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> Tested-by: Douglas Anderson <dianders@chromium.org>
>
>
>


-- 
Best Regards
Shawn Lin