mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ZhaoLong Wang <wangzhaolong1@huawei.com>
To: Richard Weinberger <richard@nod.at>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	chengzhihao1 <chengzhihao1@huawei.com>,
	yi zhang <yi.zhang@huawei.com>
Subject: Re: [PATCH 0/5] ubi: Enhanced fault injection capability for the UBI driver
Date: Sun, 23 Apr 2023 20:54:27 +0800	[thread overview]
Message-ID: <c6185f05-bbc6-355f-6061-73e81a8a0070@huawei.com> (raw)
In-Reply-To: <1751647898.236371.1682111895850.JavaMail.zimbra@nod.at>

Thank you very much for replying to my email. I agree with you.

I'll tweak my patch in the next few weeks, try to keep the old interface and
be compatible with the new interface.

Best Regards
ZhaoLong Wang

在 2023/4/22 5:18, Richard Weinberger 写道:
> ----- Ursprüngliche Mail -----
>> Von: "ZhaoLong Wang" <wangzhaolong1@huawei.com>
>> The existing fault injection capability of UBI is too simple.
>> It uses hard-coded fault probability values and lacks other
>> configurable options. As a result, these interfaces are difficult
>> to use when digging defects in the abnormal path of code and
>> reproducing some problems.
>>
>> The kernel provides a powerful fault injection framework, which
>> provides rich configurable fault injection attributes during runtime.
>> So it can be used to improve the fault injection capability of the
>> UBI driver.
>>
>> This series of patches refactor the existing fault injection interface
>> and add some fault injection types to help testers and developers
>> find potential problems in the code.
> In general I like having some new and advanced way to test UBI.
> But your patches seem to remove the old interface from debugfs,
> this will cause breakage of existing test scripts.
>
> So please keep the old interface too.
>
> Thanks,
> //richard
>

      reply	other threads:[~2023-04-23 12:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-18  1:56 ZhaoLong Wang
2023-03-18  1:56 ` [PATCH -next 1/5] ubi: Using the Fault Injection Framework to refactor the debugfs interface ZhaoLong Wang
2023-03-18  1:56 ` [PATCH -next 2/5] ubi: Split io_failures into write_failure and erase_failure ZhaoLong Wang
2023-03-18  1:56 ` [PATCH -next 3/5] ubi: Add six fault injection type for testing ZhaoLong Wang
2023-03-20 14:28   ` Zhihao Cheng
2023-03-18  1:56 ` [PATCH -next 4/5] ubi: Reserve sufficient buffer length for the input mask ZhaoLong Wang
2023-03-18  1:56 ` [PATCH -next 5/5] mtd: Add several functions to the fail_function list ZhaoLong Wang
2023-04-21 21:18 ` [PATCH 0/5] ubi: Enhanced fault injection capability for the UBI driver Richard Weinberger
2023-04-23 12:54   ` ZhaoLong Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6185f05-bbc6-355f-6061-73e81a8a0070@huawei.com \
    --to=wangzhaolong1@huawei.com \
    --cc=chengzhihao1@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®