From: "Frédéric Weisbecker" <fweisbec@gmail.com>
To: "David S. Miller" <davem@davemloft.net>,
"Linux Kernel" <linux-kernel@vger.kernel.org>
Cc: "William L. Irwin" <wli@holomorphy.com>,
Sparc <sparclinux@vger.kernel.org>
Subject: Re: [PATCH] sparc: correct section of current_pc()
Date: Tue, 21 Oct 2008 02:26:04 +0200 [thread overview]
Message-ID: <c62985530810201726w17ac4249h71c8feeb00fcd0e9@mail.gmail.com> (raw)
In-Reply-To: <48FA0F7C.9040507@gmail.com>
2008/10/18 Frederic Weisbecker <fweisbec@gmail.com>:
> Latest mainline gives this section mismatch on sparc:
>
> The function current_pc() references
> the variable __init no_sun4u_here.
> This is often because current_pc lacks a __init
> annotation or the annotation of no_sun4u_here is wrong.
>
> Since current_pc() is used only in early time, it is correct to
> put it in .init section.
>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> ---
> diff --git a/arch/sparc/kernel/head.S b/arch/sparc/kernel/head.S
> index 2d325fd..2fe2c11 100644
> --- a/arch/sparc/kernel/head.S
> +++ b/arch/sparc/kernel/head.S
> @@ -465,6 +465,7 @@ gokernel:
> mov %o7, %g4 ! Save %o7
>
> /* Jump to it, and pray... */
> + __INIT
> current_pc:
> call 1f
> nop
>
>
(Adding William and sparclinux in cc)
next parent reply other threads:[~2008-10-21 0:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <48FA0F7C.9040507@gmail.com>
2008-10-21 0:26 ` Frédéric Weisbecker [this message]
2008-10-18 16:32 Frederic Weisbecker
2008-10-22 4:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c62985530810201726w17ac4249h71c8feeb00fcd0e9@mail.gmail.com \
--to=fweisbec@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®