From: "Frédéric Weisbecker" <fweisbec@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Steven Rostedt" <rostedt@goodmis.org>,
"Linux Kernel" <linux-kernel@vger.kernel.org>
Subject: Re: Human readable output for function return tracer
Date: Tue, 25 Nov 2008 17:01:50 +0100 [thread overview]
Message-ID: <c62985530811250801u5429a346p1df8160b57b69a3e@mail.gmail.com> (raw)
In-Reply-To: <20081125155631.GA22006@elte.hu>
2008/11/25 Ingo Molnar <mingo@elte.hu>:
>
> * Ingo Molnar <mingo@elte.hu> wrote:
>
>>
>> * Ingo Molnar <mingo@elte.hu> wrote:
>>
>> > > Do you agree with "full function tracer" (since we hook now on the
>> > > two sides)?
>> >
>> > "full function tracer" sounds a bit funny and quirky. How about
>> > "function call tracer"? Versus the "function tracer" or "function
>> > entry tracer" which is the lighter variant - both in name and in
>> > overhead. So we'd have:
>> >
>> > # cat /debug/tracing/available_tracers
>> > mmiotrace wakeup irqsoff function function-call sysprof sched_switch initcall nop
>> >
>> > note how intuitive it is: "function-call" is 'more' than just the
>> > plain function-tracer. It also expresses its main property: it
>> > traces the full call, entry and exit and return code as well.
>>
>> another similar naming would be: the "function-graph" tracer.
>> function-callgraph would be too long.
>
> Steve thinks function-graph is even more expressive, so lets go with
> that instead :)
>
> it will certainly make sure there's no misunderstanding about the role
> and scope of this tracer, and it's short and expressive as well.
>
> so i'd suggest the following sed -i rules:
>
> s/FUNCTION_RET_TRACER/FUNCTION_GRAPH_TRACER/g
>
> i'd suggest to keep the ret_stack names - those are proper. (the thing
> that is used to construct the graph is the return stack)
>
> also, please do:
>
> git mv kernel/tracing/trace_functions_return.c kernel/tracing/trace_functions_graph.c
>
> and Makefile glue fixup:
>
> s/functions_return/functions_graph/g
>
> Ingo
>
Ok, and perhaps even several structures and functions.... There are
some in trace_functions_return.c, arch/x86/kernel/ftrace.c,
kernel/trace/ftrace.c
Some of them which act very close to "return hooking" should keep
their name, but for some others, I should put the graph semantics....
next prev parent reply other threads:[~2008-11-25 16:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 14:39 Frédéric Weisbecker
2008-11-24 16:27 ` Ingo Molnar
2008-11-24 17:16 ` Frédéric Weisbecker
2008-11-25 15:18 ` Frédéric Weisbecker
2008-11-25 15:36 ` Ingo Molnar
2008-11-25 15:40 ` Ingo Molnar
2008-11-25 15:49 ` Frédéric Weisbecker
2008-11-25 15:56 ` Ingo Molnar
2008-11-25 16:01 ` Frédéric Weisbecker [this message]
2008-11-24 17:21 ` Steven Rostedt
2008-11-24 17:34 ` Frédéric Weisbecker
2008-11-24 18:15 ` Arnaldo Carvalho de Melo
2008-11-24 19:10 ` Frédéric Weisbecker
2008-11-24 19:39 ` Arnaldo Carvalho de Melo
2008-11-24 20:00 ` Frédéric Weisbecker
2008-11-24 20:13 ` Frédéric Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c62985530811250801u5429a346p1df8160b57b69a3e@mail.gmail.com \
--to=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®