Re: [PATCH] tracing/function-return-tracer: set a more human readable output

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

From: "Frédéric Weisbecker" <fweisbec@gmail.com>
To: "Steven Rostedt" <rostedt@goodmis.org>
Cc: "Ingo Molnar" <mingo@elte.hu>,
	"Linux Kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing/function-return-tracer: set a more human readable output
Date: Wed, 26 Nov 2008 14:22:17 +0100	[thread overview]
Message-ID: <c62985530811260522s359bd466j83cc99050d5a304a@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0811260718570.26424@gandalf.stny.rr.com>

2008/11/26 Steven Rostedt <rostedt@goodmis.org>:
> I'd suggest just looking at how those are implemented, and use your own.
> One note, the latency tracer looks at the next entry, even if it is on
> another CPU. This is incorrect, and will definitely be incorrect for you.
> Just use the ring_buffer_iter_peek, that will get you what you want. Well,
> for leaf functions.
>
> -- Steve
>
>


Ok, thanks for your tips!

next prev parent reply	other threads:[~2008-11-26 13:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-25 23:57 Frederic Weisbecker
2008-11-26  0:39 ` Ingo Molnar
2008-11-26  2:04   ` Ingo Molnar
2008-11-26  2:10     ` [PATCH] tracing: function graph tracer, fix Ingo Molnar
2008-11-26  2:19     ` [PATCH] tracing/function-return-tracer: set a more human readable output Steven Rostedt
2008-11-26 11:32       ` Frédéric Weisbecker
2008-11-26 12:21         ` Steven Rostedt
2008-11-26 13:22           ` Frédéric Weisbecker [this message]
2008-11-26 11:11     ` Frédéric Weisbecker
2008-11-26 17:09       ` Steven Rostedt
2008-11-26  2:12   ` Ingo Molnar
2008-11-26 11:11     ` Frédéric Weisbecker
2008-11-26  2:14   ` Ingo Molnar
2008-11-26  2:21     ` Steven Rostedt
2008-11-26  2:42       ` Ingo Molnar
2008-11-26  2:51         ` Steven Rostedt
2008-11-26 11:19     ` Frédéric Weisbecker
2008-11-26 11:38       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c62985530811260522s359bd466j83cc99050d5a304a@mail.gmail.com \
    --to=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®