From: "Frédéric Weisbecker" <fweisbec@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Steven Rostedt" <rostedt@goodmis.org>,
"Tim Bird" <tim.bird@am.sony.com>,
"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
"Linux Kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing/function-graph-tracer: adjustments of the trace informations
Date: Sat, 29 Nov 2008 04:40:37 +0100 [thread overview]
Message-ID: <c62985530811281940w4542546t5a1235ad8e5a24bf@mail.gmail.com> (raw)
In-Reply-To: <20081128192249.GA22263@elte.hu>
2008/11/28 Ingo Molnar <mingo@elte.hu>:
>
> another detail: it would be nice to annotate IRQ entries some more.
>
> right now if a syscall is interrupted by a hardware interrupt, it looks
> like this:
>
> 0) | skb_dequeue() {
> 0) 0.365 us | _spin_lock_irqsave();
> 0) 0.422 us | _spin_unlock_irqrestore();
> 0) 1.912 us | }
> 0) | memcpy_toiovec() {
> 0) | copy_to_user() {
> 0) | smp_apic_timer_interrupt() {
> 0) 0.450 us | native_apic_mem_write();
> 0) | irq_enter() {
> 0) 0.410 us | idle_cpu();
> 0) 1.167 us | }
> 0) | hrtimer_interrupt() {
>
> the natural nesting is nice, but easy to miss. It would be nice to have
> something like:
>
> 0) | skb_dequeue() {
> 0) 0.365 us | _spin_lock_irqsave();
> 0) 0.422 us | _spin_unlock_irqrestore();
> 0) 1.912 us | }
> 0) | memcpy_toiovec() {
> 0) | copy_to_user() {
> 0) =====> smp_apic_timer_interrupt() {
> 0) 0.450 us | native_apic_mem_write();
> 0) | irq_enter() {
> 0) 0.410 us | idle_cpu();
> 0) 1.167 us | }
> 0) | hrtimer_interrupt() {
>
> and perhaps something like this at the end of the irq frame:
>
> 0) 0.408 us | _local_bh_enable();
> 0) + 13.139 us | }
> 0) + 13.887 us | }
> 0) 0.406 us | idle_cpu();
> 0) + 15.373 us | }
> 0) + 74.564 us | }
> 0) | _cond_resched() {
> 0) | need_resched() {
> 0) 0.423 us | constant_test_bit();
> 0) 1.164 us | }
> 0) 1.915 us <=== } /* IRQ 1 end */
> 0) + 78.396 us | }
> 0) + 79.123 us | }
> 0) 0.387 us | skb_pull();
> 0) | kfree_skb() {
>
> ?
I tried to figure out a way to signal a hardirq in a trace, I like
this arrow but It
breaks the indentation.
I would suggest:
0) | skb_dequeue() {
0) 0.365 us | _spin_lock_irqsave();
0) 0.422 us | _spin_unlock_irqrestore();
0) 1.912 us | }
0) | memcpy_toiovec() {
0) | copy_to_user() {
=====>
0) | smp_apic_timer_interrupt() {
0) 0.450 us | native_apic_mem_write();
0) | irq_enter() {
0) 0.410 us | idle_cpu();
0) 1.167 us | }
0) | hrtimer_interrupt() {
Your idea solves a part of one of the features I wanted to add: why
not using a single character column to print
the current context: workqueue, syscall, kernel thread, tasklet, hardirq .....
next prev parent reply other threads:[~2008-11-29 3:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 23:42 Frederic Weisbecker
2008-11-28 9:18 ` Ingo Molnar
2008-11-28 9:25 ` Ingo Molnar
2008-11-28 13:58 ` Frédéric Weisbecker
2008-11-28 19:22 ` Ingo Molnar
2008-11-29 3:40 ` Frédéric Weisbecker [this message]
2008-11-29 10:59 ` Peter Zijlstra
2008-11-28 13:55 ` Frédéric Weisbecker
2008-11-28 14:17 ` Ingo Molnar
2008-11-29 3:24 ` Frédéric Weisbecker
2008-11-29 14:19 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c62985530811281940w4542546t5a1235ad8e5a24bf@mail.gmail.com \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®