mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Frédéric Weisbecker" <fweisbec@gmail.com>
To: "Lai Jiangshan" <laijs@cn.fujitsu.com>
Cc: "Arnaldo Carvalho de Melo" <acme@ghostprotocols.net>,
	"Ingo Molnar" <mingo@elte.hu>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] ftrace: infrastructure for supporting binary record
Date: Tue, 6 Jan 2009 12:32:47 +0100	[thread overview]
Message-ID: <c62985530901060332q1bc92a6dk4cb1e4cd6febddba@mail.gmail.com> (raw)
In-Reply-To: <49616B0B.5000102@cn.fujitsu.com>

2009/1/5 Lai Jiangshan <laijs@cn.fujitsu.com>:
>
>>>
>>> Just for curiosity. Why do you need such a binary tracing?
>>> Do you need it because a string output is really too slow for your needs?
>
> Hi, Frederic Weisbecker,
>
> We have
> 1) lots of kinds events source(FUNCTION trace, TRACE_CTX, tracepoint, markers ...)
> 2) a generic and mature events log buffer - trace/ringbuffer.c
> 3) a generic and mature trace framework - trace/trace.c trace_ouput.c
>
> But we don't have a generic events log format, we record different
> events with different record formats: TRACE_FN, TRACE_CTX, TRACE_GRAPH_RET,
> TRACE_SPECIAL, ... We use different struct for recording different
> formats.


I understand better now. So it acts like an optimized ftrace_printk.
Instead of inserting formatted ftrace_printk entries on the ring buffer,
we insert the binary datas with the format and let the tracer decide
what to do with this,
providing a full generic entry transport....

That looks a good idea.

  reply	other threads:[~2009-01-06 11:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-31  2:56 Lai Jiangshan
2008-12-31  4:59 ` Frederic Weisbecker
2009-01-02 22:24   ` Arnaldo Carvalho de Melo
2009-01-05  2:06     ` Lai Jiangshan
2009-01-06 11:32       ` Frédéric Weisbecker [this message]
2009-01-19 19:28     ` Frédéric Weisbecker
2009-01-19 20:25       ` Arnaldo Carvalho de Melo
2009-01-19 21:08         ` Frederic Weisbecker
2009-01-19 21:37           ` Arnaldo Carvalho de Melo
2009-01-19 23:29             ` Frederic Weisbecker
2009-02-28  9:13 [PATCH][RFC] vsprintf: unify the format decoding layer for its 3 users Ingo Molnar
2009-02-28 20:16 ` [PATCH 2/5] ftrace: infrastructure for supporting binary record Frederic Weisbecker
2009-03-02 16:27   ` Steven Rostedt
2009-03-02 17:39     ` Frédéric Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c62985530901060332q1bc92a6dk4cb1e4cd6febddba@mail.gmail.com \
    --to=fweisbec@gmail.com \
    --cc=acme@ghostprotocols.net \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®