From: "Frédéric Weisbecker" <fweisbec@gmail.com>
To: "Arnaldo Carvalho de Melo" <acme@redhat.com>,
"Ingo Molnar" <mingo@elte.hu>,
"Jens Axboe" <jens.axboe@oracle.com>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Steven Rostedt" <rostedt@goodmis.org>
Subject: Re: [PATCH tip 1/1] blktrace: Use tracing_reset_online_cpus
Date: Wed, 28 Jan 2009 15:53:48 +0100 [thread overview]
Message-ID: <c62985530901280653p3febe22cu7897999dce8777e@mail.gmail.com> (raw)
In-Reply-To: <20090128143356.GG15877@ghostprotocols.net>
2009/1/28 Arnaldo Carvalho de Melo <acme@ghostprotocols.net>:
> Impact: cleanup
>
> Use tracing_reset_online_cpus instead of open coding it.
>
> Cc: Jens Axboe <jens.axboe@oracle.com>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> diff --git a/block/blktrace.c b/block/blktrace.c
> index 1b2267c..04d81d3 100644
> --- a/block/blktrace.c
> +++ b/block/blktrace.c
> @@ -1109,12 +1109,7 @@ static void blk_tracer_print_header(struct seq_file *m)
>
> static void blk_tracer_start(struct trace_array *tr)
> {
> - int cpu;
> -
> - tr->time_start = ftrace_now(tr->cpu);
> -
> - for_each_online_cpu(cpu)
> - tracing_reset(tr, cpu);
> + tracing_reset_online_cpus(tr);
>
> mutex_lock(&blk_probe_mutex);
> if (atomic_add_return(1, &blk_probes_ref) == 1)
>
Adding Steven in Cc, he uses to relay tracing patches as patchsets
pull request to Ingo.
next prev parent reply other threads:[~2009-01-28 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 14:33 Arnaldo Carvalho de Melo
2009-01-28 14:53 ` Frédéric Weisbecker [this message]
2009-01-28 14:58 ` Arnaldo Carvalho de Melo
2009-01-29 13:28 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c62985530901280653p3febe22cu7897999dce8777e@mail.gmail.com \
--to=fweisbec@gmail.com \
--cc=acme@redhat.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®