From: "Frédéric Weisbecker" <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Oleg Nesterov <oleg@redhat.com>, Mike Travis <travis@sgi.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
mm-commits@vger.kernel.org, rusty@rustcorp.com.au
Subject: Re: + work_on_cpu-rewrite-it-to-create-a-kernel-thread-on-demand.patch added to -mm tree
Date: Tue, 3 Feb 2009 17:58:13 +0100 [thread overview]
Message-ID: <c62985530902030858y28906b2dh511c5868afabfd17@mail.gmail.com> (raw)
In-Reply-To: <20090203121147.GB19979@elte.hu>
2009/2/3 Ingo Molnar <mingo@elte.hu>:
>
> * akpm@linux-foundation.org <akpm@linux-foundation.org> wrote:
>
>> ------------------------------------------------------
>> Subject: work_on_cpu(): rewrite it to create a kernel thread on demand
>> From: Andrew Morton <akpm@linux-foundation.org>
>>
>> The various implemetnations and proposed implemetnations of work_on_cpu()
>> are vulnerable to various deadlocks because they all used queues of some
>> form.
>>
>> Unrelated pieces of kernel code thus gained dependencies wherein if one
>> work_on_cpu() caller holds a lock which some other work_on_cpu() callback
>> also takes, the kernel could rarely deadlock.
>>
>> Fix this by creating a short-lived kernel thread for each work_on_cpu()
>> invokation.
>>
>> This is not terribly fast, but the only current caller of work_on_cpu() is
>> pci_call_probe().
>
> hm, it's quite ugly as well, and wasteful with resources.
Sorry I don't see the patch but only the changelog.
So perhaps my answer will be a bit out of sync.
But if pci_call_probe() is the only caller, so it is supposed to be
called only on boot.
Perhaps the work_on_cpu thread can be killed after boot up and then
become a thread created
on the fly after that if needed....
Or perhaps it's too much complex.....
next prev parent reply other threads:[~2009-02-03 16:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200902031058.n13AwOoK016719@imap1.linux-foundation.org>
2009-02-03 12:11 ` Ingo Molnar
2009-02-03 16:58 ` Frédéric Weisbecker [this message]
2009-02-03 19:25 ` Andrew Morton
2009-02-04 3:58 ` Rusty Russell
2009-02-04 4:16 ` Andrew Morton
2009-02-04 10:46 ` Rusty Russell
2009-02-12 20:38 ` Eric W. Biederman
2009-02-12 20:48 ` Andrew Morton
2009-02-12 22:08 ` Eric W. Biederman
2009-02-12 22:13 ` Eric W. Biederman
2009-02-12 22:23 ` Andrew Morton
2009-02-12 23:04 ` Eric W. Biederman
2009-02-12 22:20 ` Andrew Morton
2009-02-13 21:21 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c62985530902030858y28906b2dh511c5868afabfd17@mail.gmail.com \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mm-commits@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®