mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Frédéric Weisbecker" <fweisbec@gmail.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
	Zhaolei <zhaolei@cn.fujitsu.com>,
	Tom Zanussi <tzanussi@gmail.com>, Li Zefan <lizf@cn.fujitsu.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2 v2] tracing/events: provide string with undefined size  support
Date: Fri, 17 Apr 2009 12:04:00 +0200	[thread overview]
Message-ID: <c62985530904170304r916d978m68c275eb5618eb78@mail.gmail.com> (raw)
In-Reply-To: <1239960548.23397.4282.camel@laptop>

Le 17 avril 2009 11:29, Peter Zijlstra <a.p.zijlstra@chello.nl> a écrit :
> On Fri, 2009-04-17 at 10:59 +0200, Frédéric Weisbecker wrote:
>
>> struct foo {
>>    field1;
>>    field2;
>>    ...
>> };
>>
>> struct foo *f;
>>
>> event = ring_buffer_lock_reserve(sizeof(*f), ...);
>> f = ring_buffer_event_data(event);
>>
>> I can't use a kmalloc here. We are tracing a random event which can happen
>> at a random frequency, random context, etc...
>
> Can't you add a bit to that ring_buffer_lock_reserve() thing?
>
> The thing I do for perf_counters is I first iterate all the output, then
> make the reserve large enough to fit all the output in, then copy the
> bits into the output buffer.
>
> The result is that the output cannot be interpreted as a fixed offset
> struct, but that's not much of an issue anyway.
>
> Another possibility is using relative pointers for strings that point
> beyond the tail of the fixed offset struct.
>
> So something like:
>
>  __field(int, foo);
>  __string(bar);
>  __field(int, foo2);
>  __string(bar2);
>  __field(int, foo3);
>
> would look like:
>
>  struct plop {
>   int foo;
>   char *bar;
>   int foo2;
>   char *bar2;
>   int foo3;
>
>   char data[0];
>  }
>
> and you'd do something like:
>
>  size = sizeof(struct plop);
>  size += strlen(bar) + 1;
>  size += strlen(bar2) + 1;
>
>  event = ring_buffer_lock_reserve(size);
>  offset = sizeof(struct plop);
>  my_plop.bar = (char *)offset;
>  offset += strlen(bar) + 1;
>  my_plop.bar2 = (char *)offset;
>  memcpy(&event, &my_plop, sizeof(struct plop));
>  memcpy(&event + my_plop.bar, bar, strlen(bar)+1);
>  memcpy(&event + my_plop.bar2, bar2, strlen(bar2)+1);
>  ring_buffer_unlock();
>
> Then on reading, you'd get a variable sized entry, with a fixed size
> fixed offset struct, that contains relative offset character pointers.



I like much this idea.
Just a small change on it: I could use absolute addresses

offset = sizeof(struct plop);
my_plop.bar = &entry + offset;
offset += strlen(str1) + 1;
my_plop.bar2 = &entry + offset;
strcpy(my_plop.bar, str1);
strcpy(my_plop.bar2, str2);

So that its integration will need very few changes to support printing
and filtering. It will just behave like usual char [..].

Nice! Thanks Peter.

  reply	other threads:[~2009-04-17 10:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-16 20:00 Frederic Weisbecker
2009-04-16 20:00 ` [PATCH 2/2 v2] tracing/lock: provide lock_acquired event support for dynamic size string Frederic Weisbecker
2009-04-16 20:13 ` [PATCH 1/2 v2] tracing/events: provide string with undefined size support Peter Zijlstra
2009-04-16 20:28   ` Frédéric Weisbecker
2009-04-17  6:22     ` Peter Zijlstra
2009-04-17  8:59       ` Frédéric Weisbecker
2009-04-17  9:29         ` Peter Zijlstra
2009-04-17 10:04           ` Frédéric Weisbecker [this message]
2009-04-17 10:07             ` Frédéric Weisbecker
2009-04-17 10:10           ` Steven Rostedt
2009-04-17 10:16             ` Frédéric Weisbecker
2009-04-17 10:39             ` Peter Zijlstra
2009-04-17 10:51               ` Steven Rostedt
2009-04-17 11:14                 ` Frédéric Weisbecker
2009-04-17 10:39             ` Steven Rostedt
2009-04-18 18:42               ` Frederic Weisbecker
2009-04-19  0:52                 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c62985530904170304r916d978m68c275eb5618eb78@mail.gmail.com \
    --to=fweisbec@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=tzanussi@gmail.com \
    --cc=zhaolei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®