mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Frédéric Weisbecker" <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 03/11] tracing: export stats of ring buffers to userspace
Date: Wed, 6 May 2009 12:23:48 +0200	[thread overview]
Message-ID: <c62985530905060323o3983bd3ap34640018d5a46be6@mail.gmail.com> (raw)
In-Reply-To: <20090506082814.GB28675@elte.hu>

2009/5/6 Ingo Molnar <mingo@elte.hu>:
>
> * Steven Rostedt <rostedt@goodmis.org> wrote:
>
>> From: Steven Rostedt <srostedt@redhat.com>
>>
>> This patch adds stats to the ftrace ring buffers:
>>
>>  # cat /debugfs/tracing/per_cpu/cpu0/stats
>>  entries: 42360
>>  overrun: 30509326
>>  commit overrun: 0
>>  nmi dropped: 0
>>
>> Where entries are the total number of data entries in the buffer.
>>
>> overrun is the number of entries not consumed and were overwritten by
>> the writer.
>>
>> commit overrun is the number of entries dropped due to nested writers
>> wrapping the buffer before the initial writer finished the commit.
>>
>> nmi dropped is the number of entries dropped due to the ring buffer
>> lock being held when an nmi was going to write to the ring buffer.
>> Note, this field will be meaningless and will go away when the ring
>> buffer becomes lockless.
>>
>> [ Impact: let userspace know what is happening in the ring buffers ]
>
> nice! I was always wondering about these properties - Frederic
> reported that we drop a lot of trace entries when filtering is
> enabled, due to the rather stupid:
>
>        reserve-buffer
>        put-stuff-into-buffer
>        drop-buffer-if-filter-false
>
> common sequence we do on heavily filtered input.
>
>        Ingo


But I think I was wrong actually.
I looked at it closer recently and the lock events are traced in a
raw_local_irq_save section.

So the cause is elsewhere. I haven't had anymore problem with it
recently, may be because I'm using a script
which disables the events once I finish the tracing.

  reply	other threads:[~2009-05-06 10:24 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-06  4:21 [PATCH 00/11] [GIT PULL] tracing/ring-buffer: various updates Steven Rostedt
2009-05-06  4:21 ` [PATCH 01/11] ring-buffer: export symbols Steven Rostedt
2009-05-06  4:21 ` [PATCH 02/11] ring-buffer: add counters for commit overrun and nmi dropped entries Steven Rostedt
2009-05-06  4:21 ` [PATCH 03/11] tracing: export stats of ring buffers to userspace Steven Rostedt
2009-05-06  8:28   ` Ingo Molnar
2009-05-06 10:23     ` Frédéric Weisbecker [this message]
2009-05-06  4:21 ` [PATCH 04/11] ring-buffer: convert cpu buffer entries to local_t Steven Rostedt
2009-05-06  4:21 ` [PATCH 05/11] ring-buffer: record page entries in buffer page descriptor Steven Rostedt
2009-05-06  4:21 ` [PATCH 06/11] ring-buffer: have read page swap increment counter with page entries Steven Rostedt
2009-05-06  4:21 ` [PATCH 07/11] ring-buffer: disable writers when resetting buffers Steven Rostedt
2009-05-06  4:21 ` [PATCH 08/11] ftrace: use .sched.text, not .text.sched in recordmcount.pl Steven Rostedt
2009-05-06  4:21 ` [PATCH 09/11] tracing: use proper export symbol for tracing api Steven Rostedt
2009-05-06  4:21 ` [PATCH 10/11] ring-buffer: move big if statement down Steven Rostedt
2009-05-06  8:24   ` Ingo Molnar
2009-05-06 13:47     ` Steven Rostedt
2009-05-06 14:37       ` Ingo Molnar
2009-05-06  4:21 ` [PATCH 11/11] ring-buffer: add benchmark and tester Steven Rostedt
2009-05-06  8:53   ` Ingo Molnar
2009-05-06 14:02     ` Steven Rostedt
2009-05-06 19:43     ` Steven Rostedt
2009-05-06 20:58       ` Ingo Molnar
2009-05-06  8:28 ` [PATCH 00/11] [GIT PULL] tracing/ring-buffer: various updates Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c62985530905060323o3983bd3ap34640018d5a46be6@mail.gmail.com \
    --to=fweisbec@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®