mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Frédéric Weisbecker" <fweisbec@gmail.com>
To: rostedt@goodmis.org
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@elte.hu>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] trace: export trace_profile_buf symbols
Date: Mon, 21 Sep 2009 09:23:12 +0200	[thread overview]
Message-ID: <c62985530909210023p7707b9efwc4a994522e53fa72@mail.gmail.com> (raw)
In-Reply-To: <1253445829.20020.626.camel@gandalf.stny.rr.com>

Le 20 septembre 2009 13:23, Steven Rostedt <rostedt@goodmis.org> a écrit :
> On Sun, 2009-09-20 at 12:34 +0200, Peter Zijlstra wrote:
>> ERROR: "trace_profile_buf_nmi" [fs/jbd2/jbd2.ko] undefined!
>> ERROR: "trace_profile_buf" [fs/jbd2/jbd2.ko] undefined!
>> ERROR: "trace_profile_buf_nmi" [fs/ext4/ext4.ko] undefined!
>> ERROR: "trace_profile_buf" [fs/ext4/ext4.ko] undefined!
>> ERROR: "trace_profile_buf_nmi" [arch/x86/kvm/kvm.ko] undefined!
>> ERROR: "trace_profile_buf" [arch/x86/kvm/kvm.ko] undefined!
>>
>
> Peter, I thought you never use modules.


And I forgot to think about them :-/


>> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>

Acked-by: Frederic Weisbecker <fweisbec@gmail.com>



>
> -- Steve
>
>> ---
>>  kernel/trace/trace_event_profile.c |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/kernel/trace/trace_event_profile.c b/kernel/trace/trace_event_profile.c
>> index 3aaa77c..f65e966 100644
>> --- a/kernel/trace/trace_event_profile.c
>> +++ b/kernel/trace/trace_event_profile.c
>> @@ -17,6 +17,9 @@ typedef struct {char buf[FTRACE_MAX_PROFILE_SIZE];} profile_buf_t;
>>  char         *trace_profile_buf;
>>  char                 *trace_profile_buf_nmi;
>>
>> +EXPORT_SYMBOL_GPL(trace_profile_buf);
>> +EXPORT_SYMBOL_GPL(trace_profile_buf_nmi);
>> +
>>  /* Count the events in use (per event id, not per instance) */
>>  static int   total_profile_count;
>>
>>
>>
>
>

  reply	other threads:[~2009-09-21  7:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-20 10:34 Peter Zijlstra
2009-09-20 11:23 ` Steven Rostedt
2009-09-21  7:23   ` Frédéric Weisbecker [this message]
2009-09-20 17:40 ` [tip:tracing/urgent] tracing: Export " tip-bot for Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c62985530909210023p7707b9efwc4a994522e53fa72@mail.gmail.com \
    --to=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®