From: "Frédéric Weisbecker" <fweisbec@gmail.com>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: Steven Rostedt <srostedt@redhat.com>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trace: fix missing assignment in trace_ctxwake_*
Date: Fri, 2 Oct 2009 14:49:00 +0200 [thread overview]
Message-ID: <c62985530910020549q72cbb2fav43c4a6e191239b0c@mail.gmail.com> (raw)
In-Reply-To: <4AC43118.6050409@ct.jp.nec.com>
2009/10/1 Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>:
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>
> The state char variable S should be reassigned, if S == 0.
>
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Good catch, we are indeed missing the state of the task that is going to sleep
for the context switch events (in the raw mode).
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Fortunately the problem arises with the sched_switch/wake_up tracers, not
the sched trace events.
The formers are legacy now. But still, that was buggy.
Thanks.
next prev parent reply other threads:[~2009-10-02 12:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 4:33 Hiroshi Shimamoto
2009-10-02 12:49 ` Frédéric Weisbecker [this message]
2009-10-02 14:00 ` [tip:tracing/urgent] trace: Fix " tip-bot for Hiroshi Shimamoto
2009-10-06 12:49 ` tip-bot for Hiroshi Shimamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c62985530910020549q72cbb2fav43c4a6e191239b0c@mail.gmail.com \
--to=fweisbec@gmail.com \
--cc=h-shimamoto@ct.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®