From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751291AbdCMIhi (ORCPT ); Mon, 13 Mar 2017 04:37:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56358 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750864AbdCMIha (ORCPT ); Mon, 13 Mar 2017 04:37:30 -0400 Subject: Re: [PATCH] KVM: nVMX: don't reset kvm mmu twice To: Wanpeng Li , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <1489308832-29078-1-git-send-email-wanpeng.li@hotmail.com> Cc: Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Wanpeng Li From: David Hildenbrand Organization: Red Hat GmbH Message-ID: Date: Mon, 13 Mar 2017 09:37:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1489308832-29078-1-git-send-email-wanpeng.li@hotmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 13 Mar 2017 08:37:19 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 12.03.2017 um 09:53 schrieb Wanpeng Li: > From: Wanpeng Li > > kvm mmu is reset once successfully loading CR3 as part of emulating vmentry > in nested_vmx_load_cr3(). We should not reset kvm mmu twice. > > Cc: Paolo Bonzini > Cc: Radim Krčmář > Signed-off-by: Wanpeng Li > --- > arch/x86/kvm/vmx.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index 98e82ee..bca8d7a 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -10286,8 +10286,6 @@ static int prepare_vmcs02(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12, > entry_failure_code)) > return 1; > > - kvm_mmu_reset_context(vcpu); > - > if (!enable_ept) > vcpu->arch.walk_mmu->inject_page_fault = vmx_inject_page_fault_nested; > > Reviewed-by: David Hildenbrand -- Thanks, David