From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from canpmsgout04.his.huawei.com (canpmsgout04.his.huawei.com [113.46.200.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B14EA385501 for ; Tue, 10 Mar 2026 03:23:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.219 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773113023; cv=none; b=WN9avRb/QsN/02tQJylXaBHHl6s4XZ1LB3xk+oZI//TGx2+Hg7wHc+qdHrv7zuCrY890uk6axoQnAuNmnj2hzkgHY+AqzA0Dtqxys97PILMl+NSB0EYEhw2IT1suzmFdQ+GbReLaU+1HcV5iOOe6G5JAMNOtXfArRF0/0xQpI70= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773113023; c=relaxed/simple; bh=cu3eYMh01ifN9L3AJwLtGqgTJfDzk/jNu+BkNnzZi2E=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=NmUJyiNsJsvoZ0mkxEpnyNeFGTn06hwHYlEVZVg3XWKW0DeNiAQP5LqyNgCnPtQsn+iIwKwlIzmAL0mjREb5LO77I8xnyWiuABZBNXZOP1kTnSGW4ADl/KDJ1Ue5b+K9m60nR84SFR5Aq2RGqINNPEUFkewbHYJNiG1MMhRGypw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=KTohcUNo; arc=none smtp.client-ip=113.46.200.219 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="KTohcUNo" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=l9aCjyy9Ivp4IuGzOf68ouXeTqJVl/1CRtfxbUD2mUY=; b=KTohcUNo5yPnpBwxWNsiG0U2ABQUIN+6YMbTKUL9F0hOHqWYPe6XTb3uVVGTwpaSdRC9wnNRX LoeD4efi4BqwN+J8YRKKo63ISlpCFMYEuPrxVwbDIs6mO5+IgrzSSvmq4bCyo94ZiqWHF66/w91 SajYWi4QM9z3Z+u8+/ug3ZE= Received: from mail.maildlp.com (unknown [172.19.162.140]) by canpmsgout04.his.huawei.com (SkyGuard) with ESMTPS id 4fVJxY6sKnz1prKR; Tue, 10 Mar 2026 11:18:41 +0800 (CST) Received: from kwepemr500001.china.huawei.com (unknown [7.202.194.229]) by mail.maildlp.com (Postfix) with ESMTPS id CEFF720104; Tue, 10 Mar 2026 11:23:38 +0800 (CST) Received: from [10.174.179.248] (10.174.179.248) by kwepemr500001.china.huawei.com (7.202.194.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 10 Mar 2026 11:23:36 +0800 Message-ID: Date: Tue, 10 Mar 2026 11:23:36 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v3 1/4] x86/mm: Use proper page table helpers for huge page generation To: Jonathan Cameron CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20260228070906.1418911-1-yintirui@huawei.com> <20260228070906.1418911-2-yintirui@huawei.com> <20260306092903.0000268f@huawei.com> From: Yin Tirui In-Reply-To: <20260306092903.0000268f@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: kwepems100001.china.huawei.com (7.221.188.238) To kwepemr500001.china.huawei.com (7.202.194.229) On 3/6/2026 5:29 PM, Jonathan Cameron wrote: > Whilst you are here, can we make that a one liner. > entry = pfn_pmd(__pa(p) >> PAGE_SHIFT, PAGE_KERNEL_LARGE); > > Could even do > > pmd_t entry = pfn_pmd(__pa(p) >> PAGE_SHIFT, PAGE_KERNEL_LARGE); > but that's more of a question of taste. Hi Jonathan, Thanks for the suggestion, I will fold this one-liner cleanup into the next respin. -- Yin Tirui