From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Alexander Larsson <alexl@redhat.com>,
Jingbo Xu <jefflexu@linux.alibaba.com>
Cc: chao@kernel.org, huyue2@coolpad.com,
linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 0/2] erofs: introduce bloom filter for xattr
Date: Tue, 4 Jul 2023 17:15:14 +0800 [thread overview]
Message-ID: <c630bb18-2a50-13ed-f100-c4e40860e04b@linux.alibaba.com> (raw)
In-Reply-To: <CAL7ro1Hhiq=qofFLgxjMDZnrwJ6E=tvcECqqbP8vQ_CeJLtSKQ@mail.gmail.com>
On 2023/7/4 16:05, Alexander Larsson wrote:
> On Tue, Jul 4, 2023 at 7:56 AM Jingbo Xu <jefflexu@linux.alibaba.com> wrote:
>>
>>
...
>> ```
>> seed: 25bbe08f
>> bit 31: trusted.overlay.metacopy, user.overlay.metacopy,
>>
>> seed: cc922efd
>> bit 3: trusted.overlay.opaque, user.overlay.opaque,
>>
>> seed: cd478c17
>> bit 6: trusted.overlay.metacopy, user.overlay.metacopy,
>> ```
>>
>>
>> Any other idea?
>
> Any of these three is good to me. I don't have any ideas directly
> related to this. However, semi-related, it would be really cool if
> fuse supported the same approach for xattr lookup. I.e. if lookup
> could add a bloom filter value as part of the inode data, then we
> could avoid a kernel<->fusefs-d transition for negative xattrs
> lookups.
I think we could just use a hardcoded magic number (e.g. 25bbe08f)
as a start first, since it seems already fulfill our requirement
and it's a compatible feature (and the implementation is also not
complex.) So I'm not quite worried about this.
Thanks,
Gao Xiang
>
prev parent reply other threads:[~2023-07-04 9:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 8:32 Jingbo Xu
2023-06-21 8:32 ` [RFC 1/2] erofs: update on-disk format for xattr bloom filter Jingbo Xu
2023-06-27 2:12 ` Gao Xiang
2023-06-21 8:32 ` [RFC 2/2] erofs: optimize getxattr with " Jingbo Xu
2023-06-21 11:50 ` [RFC 0/2] erofs: introduce bloom filter for xattr Alexander Larsson
2023-06-22 6:36 ` Jingbo Xu
2023-06-22 7:56 ` Alexander Larsson
2023-06-24 1:31 ` Jingbo Xu
2023-06-28 3:38 ` Jingbo Xu
2023-07-03 7:25 ` Alexander Larsson
2023-07-03 9:07 ` Jingbo Xu
2023-07-04 5:56 ` Jingbo Xu
2023-07-04 8:05 ` Alexander Larsson
2023-07-04 9:15 ` Gao Xiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c630bb18-2a50-13ed-f100-c4e40860e04b@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=alexl@redhat.com \
--cc=chao@kernel.org \
--cc=huyue2@coolpad.com \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®