From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 542F43EB7F8 for ; Fri, 27 Mar 2026 13:05:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774616714; cv=none; b=L91457TiRHGuZkT6RASs8ljy9MzjFvf1u7ylhIlY4hguKx1jds4hrZSc14VePem7pygM8qAfXDq/FN+swBRiujU4szz0xv6UwSClOmRgu5uhDNO2FomLdsqJ3th+74dX5H5PLxoBO/UrIcGEfNCKbdXU82ZhneLzXsfPFbGF9CY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774616714; c=relaxed/simple; bh=HM0UqkLUu9WqALVJU2c5Cv63fC0p8hZ2Hqz8KblmXZQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=J4tjzz0lGzTzsGNzw3CCpFTWtYLSs1/QLdWfD0lkDcY/xxa5eKfMR77Hq00GNHj7GCV+OvNnK4fBeu/xmTqJtMEAX7zlp+hSKA0aP7icPqvUIjGbwIWMh4DjBJOolxvWhp++2C5+sDtuJDdKVQgNwPNGASYHeF404XEEUQirOuA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EHwkPbNh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ChohL3Ox; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EHwkPbNh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ChohL3Ox" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62RCmIgH2378942 for ; Fri, 27 Mar 2026 13:05:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vfDlh3o5rWgfZDS7lEAmkiCGhj1ewWw3OQldssX7OhU=; b=EHwkPbNh+KpdhkQN 6mV8U5x55Js2M/cmZRe8Xd2+9xxqoL/jYEGUXzxvjTeNTkfmNI0fflrMkLOm/w+3 RKzQYUuDzpS9WFBEmI8YgUKweNg6YNF/p1pPf3NVZ3tY0m72VYU2gtBRK0F7MpMB r6kiQcf/ZyADM+gstE1zzzy666QnKogqosi3qa73n0Z4Wo+Pmk/iqL7g/8FOpVWP 8eGAw0yJrxXSiFuHTYNnLdi8rDCaleQ21U+BjhVanmH242/9P/FFYd53kAnrFoNq xlxbmTIrrePhfWTDac2ZLAswZmzlRzR6ptmRAKfaYnaxR3CcROgGvoWzi4RwgHNp X9lozw== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d5jcx1x1n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 27 Mar 2026 13:05:12 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-604ea7bd707so123056137.1 for ; Fri, 27 Mar 2026 06:05:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774616712; x=1775221512; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vfDlh3o5rWgfZDS7lEAmkiCGhj1ewWw3OQldssX7OhU=; b=ChohL3OxkOei2BZpFPO4yRzNRgcb/NxZrmc+3KSqvKFHgJQKJkiwCNjVpygmLsanNd sS76GKH48IsZwcnUWhqA2LlkK+JqNJ72EbCs9NCH8tcGW4gZca6G8UIH4Em4shMWfzPX wmrDxSWaePD2e+yl01mquflaQebUUEy1nCrmPJmrs6NkdW4tAMfyxz7/BaZ5UZgdf6yM 25bwviQK/JhqsS8VG5wYjLGomq5ddo8JVQX1MrzbFqH9LnReahZF4XGQK1hb7V2sl7GI eDNVmwlaKBUg+N/m//4aFW2TEhxPT1Law8hA565Xk0pBtKTSdvMm+WdADwWE1Yw+pU6n 0SUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774616712; x=1775221512; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vfDlh3o5rWgfZDS7lEAmkiCGhj1ewWw3OQldssX7OhU=; b=WQossHwYUg2UT2oTRSLQQrG8t05ow/F+MmhKBK9ZrbYXEktBtYnkGtWnBLDIvfB430 P0ebxafJL6BhwHGFaHxHvTzrUwQfjmVDmmiDfB/6dMBhLBNzY6N/htAQzUAwn/Jc9xKt d3r3q9euOwaZqWolKAfLEyvdXberbkJyyiYbKmpRPplgS7wMLFup7MuwV9IlNPN3XfCc 4ZkgC0SGmpN2vASNoygazCjbB1osez0tuuGGc/ELT4vsQJeOmvUBM66E+jJNGPBYJL2Z OCowU2RvwzszY8+QIwoN5LKkD4ntNqtZdt1ANLYq8s/sv+xUDCjP9urIVSqOnp2h3syw SWug== X-Forwarded-Encrypted: i=1; AJvYcCUG+gRNF9sjzfVcMUI2N30ObAgbPmD+G4BDUKhA+89hHu+bv6E/ChgxteziGWJcNlJBNIa1Frq+hdp+97M=@vger.kernel.org X-Gm-Message-State: AOJu0YxvmQg5P7kg38w4Mvck4EwgRbdslZ9gGMv5iMX62rBMvOay0xTQ Fw6IaEB4x6KlCzNdpViT2mFO7ujI7809IPXq8F6+QwyxX70jXVnKNWQUusD9fw/67Mc6xdabXxe Vc7VzQOw8FuWQ1gvJVb0AlnklgIkEkmw3udgOOGOPyTBC79H5Sy+DUjGtiYqzZj/KX0s= X-Gm-Gg: ATEYQzzO2osHDMBaJ93j5aM2Oz3OTP8bjvjfTytxyyxfxEtbL5d+g7vRSbbadisx1Ku b4lJGDql0/BH4prZmm8EwzD7HqSotTx5kX03pEBaXtirhV8/O7rdVwkBJAWndNp+mpsomrNvCNL HlxBMZre8+fKtFEwJOAfjQL9zIf0EVmlYXyq227+HrMxdclUUKPwFI/V9pPNBnfygipm6ASnQhF x0bdqw2mJwGqEDRzIOonNakYmfcnq+mjhfW9FNzFZ5EeN5mRLF2VJKYbcyHguELsyNxCx6pDsHE 9Wo0hS/BWGBDWcfJoL0qe/AfJIbP9Ck90OKJqbDmnIAQISxQAPr3U3FwDoN20VrIF81mzKHMS8X dJ/eVjA4dXEXWH3MO2H2q0s+BpfFVdRfBjN5LHujAchvaXxYqYIZW3tLCVlHriK3R5ViElbbmNH ivwPM= X-Received: by 2002:a05:6102:2423:b0:5f5:46f8:465f with SMTP id ada2fe7eead31-604f92c14e1mr304040137.5.1774616711452; Fri, 27 Mar 2026 06:05:11 -0700 (PDT) X-Received: by 2002:a05:6102:2423:b0:5f5:46f8:465f with SMTP id ada2fe7eead31-604f92c14e1mr303995137.5.1774616710719; Fri, 27 Mar 2026 06:05:10 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9b203ef860sm247393866b.48.2026.03.27.06.05.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Mar 2026 06:05:09 -0700 (PDT) Message-ID: Date: Fri, 27 Mar 2026 14:05:08 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gpio: shared: call gpio_chip::of_xlate() if set To: Jon Hunter , Bartosz Golaszewski , Linus Walleij , Bartosz Golaszewski , Abel Vesa , Sibi Sankar Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, "linux-tegra@vger.kernel.org" References: <20260316-gpio-shared-xlate-v1-1-0ce07a1362d2@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=NfTrFmD4 c=1 sm=1 tr=0 ts=69c68088 cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=Ikd4Dj_1AAAA:8 a=EUspDBNiAAAA:8 a=4Zt-9WjB5CLmpKvnE1MA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-GUID: s4r64vuzE2S9Hv4CeCFPItnHgFRL7nZg X-Proofpoint-ORIG-GUID: s4r64vuzE2S9Hv4CeCFPItnHgFRL7nZg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI3MDA4OSBTYWx0ZWRfX5IoICpYsWFS4 1D0dRCGhKWxF6QrifV5OHJ7+WbkBb20LKgX7wMp0RQF541JHw9qAyJGj0yDuEzvn8m3EvIDAUiK /2Pa123Nm2V77bqTchJwMc7AUyVt/NaDGZx8wuZOhlOhGObG6oO68eqaXNhZ/wPrTphZ3Cfq/gp 3ew4WYvltsM9gaN6oJ7QOGMxHsYq1RYtrzpif8AKiYhdyfKee5BdpVOwSOnc14hL4MmiA9z6/eR OMsYgBQ2Xm2XOtVfc6GQCyJ6nD3L3XuYz3GiIow9exJE9jMAFryxKtD4/O2Cr+pTQXoicWgQ+Cf 0PT9aEmFW+Aga2smSOMy/ToZ6D5RlxABsSO+S6/ehrXeSLINYOP0SsR9uR69yR1hYrwk/dN684i itIiG3vdBPKoKp5fbRLPYskcAyJwk1vdunaVCmuf2yQyd92ubU/jEC3qVW4wHuWj3oFhp0d5h71 f8LLeVHuGOj5Rq0zBbw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_04,2026-03-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 bulkscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603270089 On 3/17/26 11:12 AM, Jon Hunter wrote: > Hi Bartosz, > > On 16/03/2026 13:52, Bartosz Golaszewski wrote: >> OF-based GPIO controller drivers may provide a translation function that >> calculates the real chip offset from whatever devicetree sources >> provide. We need to take this into account in the shared GPIO management >> and call of_xlate() if it's provided and adjust the entry->offset we >> initially set when scanning the tree. >> >> To that end: modify the shared GPIO API to take the GPIO chip as >> argument on setup (to avoid having to rcu_dereference() it from the GPIO >> device) and protect the access to entry->offset with the existing lock. >> >> Fixes: a060b8c511ab ("gpiolib: implement low-level, shared GPIO support") >> Reported-by: Jon Hunter >> Closes: https://lore.kernel.org/all/921ba8ce-b18e-4a99-966d-c763d22081e2@nvidia.com/ >> Signed-off-by: Bartosz Golaszewski >> --- [...] > Thanks for sending this. However, I am seeing a different issue now ... > >  ------------[ cut here ]------------ >  WARNING: drivers/gpio/gpiolib-shared.c:499 at gpio_shared_add_proxy_lookup+0x118/0x1d8, CPU#8: swapper/0/1 Not only this, this breaks suspend on the Qualcomm X1E CRD (probably all /most QC devices by extension) +CC Abel, Sibi in case this is what you've been chasing with the patch: [rootfs ]# echo mem > /sys/power/state [ 226.043580] PM: suspend entry (deep) [ 226.047470] Filesystems sync: 0.000 seconds [ 226.058513] Freezing user space processes [ 226.066296] Freezing user space processes completed (elapsed 0.003 seconds) [ 226.073489] OOM killer disabled. [ 226.076843] Freezing remaining freezable tasks [ 226.082353] Freezing remaining freezable tasks completed (elapsed 0.000 seconds) (give it some time, it dies) without the patch: [rootfs ]# echo mem > /sys/power/state [ 38.047570] PM: suspend entry (deep) [ 38.053506] Filesystems sync: 0.001 seconds [ 38.082615] Freezing user space processes [ 38.092528] Freezing user space processes completed (elapsed 0.005 seconds) [ 38.099860] OOM killer disabled. [ 38.103222] Freezing remaining freezable tasks [ 38.110329] Freezing remaining freezable tasks completed (elapsed 0.002 seconds) [ 38.469231] dwc3-qcom-legacy a0f8800.usb: port-1 HS-PHY not in L2 [ 38.652848] Disabling non-boot CPUs ... [ 38.668957] IRQ205: set affinity failed(-22). [ 38.669018] IRQ206: set affinity failed(-22). [ 38.669029] IRQ207: set affinity failed(-22). [ 38.670351] IRQ274: set affinity failed(-22). [ 38.671257] psci: CPU11 killed (polled 0 ms) [ 38.712308] IRQ205: set affinity failed(-22). [ 38.712323] IRQ206: set affinity failed(-22). [ 38.712333] IRQ207: set affinity failed(-22). [ 38.713634] IRQ274: set affinity failed(-22). [ 38.713821] psci: CPU10 killed (polled 0 ms) [ 38.754187] IRQ205: set affinity failed(-22). [ 38.754202] IRQ206: set affinity failed(-22). [ 38.756479] psci: CPU9 killed (polled 0 ms) [ 38.789962] psci: CPU8 killed (polled 0 ms) [ 38.803178] psci: CPU7 killed (polled 0 ms) [ 38.816286] psci: CPU6 killed (polled 0 ms) [ 38.828479] psci: CPU5 killed (polled 0 ms) [ 38.847479] psci: CPU4 killed (polled 0 ms) [ 38.873528] psci: CPU3 killed (polled 0 ms) [ 38.894399] psci: CPU2 killed (polled 0 ms) [ 38.905818] psci: CPU1 killed (polled 0 ms) [ 38.912658] Enabling non-boot CPUs ... (resumes just fine) Konrad