From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E57FC77B79 for ; Mon, 17 Apr 2023 06:03:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229655AbjDQGDI (ORCPT ); Mon, 17 Apr 2023 02:03:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229929AbjDQGC7 (ORCPT ); Mon, 17 Apr 2023 02:02:59 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC22A3ABA; Sun, 16 Apr 2023 23:02:57 -0700 (PDT) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33H5PxmY012715; Mon, 17 Apr 2023 06:02:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=34taamsEjzMtcUYQrArKiuW9bRD33U8+uixJpo4cjkY=; b=bpXEsHbGdx08WqeleEvhRclgBCVq6PNP136+vvFQo8jHOV/jMIBytfrmrq8vQJ88hIsV nJ4v1RVixhSwd49H44ylC8D0zIXc7q3KZXJmXWOYRK1ceHId8gEsZly3FxMd2Br9G9ol vAwTp9b5QK4hk1iZ1Fxmg3PcqpGb2SAwjTdiogCGMauF4yCXMpQwuQZ08xGrI7O4a6dT ITdtsNGCnDiObDVcnI/JewcpaHzq8bspkfurdcPAGOL3DHfuzqwFOdGuuz3skwNk51Zq Y203Ixzr4L6U6jgIUcZFVEiUmgzJGBcpb/zFqG+ko6gTD6vz8pP752lUz3ORJfLr28y/ Mg== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3pymmg2qca-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Apr 2023 06:02:45 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 33H62UhP004527 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Apr 2023 06:02:44 GMT Received: from [10.216.30.175] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Sun, 16 Apr 2023 23:02:21 -0700 Message-ID: Date: Mon, 17 Apr 2023 11:32:17 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH V3 8/9] arm64: dts: Add ipq5018 SoC and rdp432-c2 board support Content-Language: en-US To: Konrad Dybcio , , , , , , , , , , , , , , , , , CC: Varadarajan Narayanan , Gokul Sriram Palanisamy References: <1681468167-11689-1-git-send-email-quic_srichara@quicinc.com> <1681468167-11689-9-git-send-email-quic_srichara@quicinc.com> <01b21803-9367-f253-3b66-b0a6c1d93cf2@linaro.org> From: Sricharan Ramabadhran In-Reply-To: <01b21803-9367-f253-3b66-b0a6c1d93cf2@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: eb2W7Ida1xdw8oz4z0I_4gR4LHVlyDZ5 X-Proofpoint-GUID: eb2W7Ida1xdw8oz4z0I_4gR4LHVlyDZ5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-17_02,2023-04-14_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015 bulkscore=0 malwarescore=0 mlxlogscore=756 suspectscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 spamscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304170055 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/14/2023 5:01 PM, Konrad Dybcio wrote: > > > On 14.04.2023 12:29, Sricharan Ramabadhran wrote: >> Add initial device tree support for the Qualcomm IPQ5018 SoC and >> rdp432-c2 board. >> >> Co-developed-by: Varadarajan Narayanan >> Signed-off-by: Varadarajan Narayanan >> Co-developed-by: Gokul Sriram Palanisamy >> Signed-off-by: Gokul Sriram Palanisamy >> Signed-off-by: Sricharan Ramabadhran >> --- >> [v3] Fixed all review comments and DTS schema warnings > This is too vague. > Ha ok, infact below is the list of changes from V2 -> V3 *) Sorted the nodes based on address. *) Removed the pcie fixed clocks. *) Changed the board file name. *) Added SDHCI nodes/pins. *) Fixed the DT schema warnings. *) Fixed rest of comments. > [...] > >> + >> + v2m1: v2m@1000 { >> + compatible = "arm,gic-v2m-frame"; >> + reg = <0x00001000 0xffd>; > Doesn't this exceed the ranges=<> of &intc? > Right, thanks for the catch. Will fix it. Regards, Sricharan