From: Krzysztof Kozlowski <krzk@kernel.org>
To: petri.karhula@novatron.fi,
Thomas Richard <thomas.richard@bootlin.com>,
Lee Jones <lee@kernel.org>, Daniel Thompson <danielt@kernel.org>,
Jingoo Han <jingoohan1@gmail.com>, Helge Deller <deller@gmx.de>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2 1/2] backlight: Add Congatec Board Controller (CGBC) backlight support
Date: Thu, 20 Nov 2025 15:09:57 +0100 [thread overview]
Message-ID: <c636a799-5b8c-4f1b-a3e5-74c9df63977d@kernel.org> (raw)
In-Reply-To: <20251119-cgbc-backlight-v2-1-4d4edd7ca662@novatron.fi>
On 19/11/2025 09:25, Petri Karhula via B4 Relay wrote:
> +}
> +
> +/**
> + * Remove function for CGBC backlight driver
> + * @pdev: Platform device
> + *
> + * The Linux device-managed resource framework (devres) does the cleanup.
> + * No explicit cleanup is needed here.
> + */
> +static void cgbc_bl_remove(struct platform_device *pdev)
> +{
> + dev_info(&pdev->dev, "CGBC backlight driver removed\n");
> +}
I reviewed v1, but all comments are applicable.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-20 14:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 8:25 [PATCH v2 0/2] Backlight driver to control backlight behind Congatec Board Controller Petri Karhula via B4 Relay
2025-11-19 8:25 ` [PATCH v2 1/2] backlight: Add Congatec Board Controller (CGBC) backlight support Petri Karhula via B4 Relay
2025-11-20 9:09 ` Thomas Richard
2025-11-24 14:10 ` Petri Karhula
2025-11-20 14:09 ` Krzysztof Kozlowski [this message]
2025-11-19 8:25 ` [PATCH v2 2/2] mfd: cgbc: Add support for backlight Petri Karhula via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c636a799-5b8c-4f1b-a3e5-74c9df63977d@kernel.org \
--to=krzk@kernel.org \
--cc=danielt@kernel.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petri.karhula@novatron.fi \
--cc=thomas.richard@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®