From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 506DFC0015E for ; Wed, 26 Jul 2023 08:45:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233182AbjGZIpz (ORCPT ); Wed, 26 Jul 2023 04:45:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233113AbjGZIp1 (ORCPT ); Wed, 26 Jul 2023 04:45:27 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A160E0; Wed, 26 Jul 2023 01:36:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=RAU0cPXH92fccMay1mm1XuQEOIvzdh7WIU3f587dsCI=; b=19FUvKyFVXqzZLN143udiZB+9n jOVsdfJXaR0AVtp6/XVgx6Q6mG7vMGdXjzfQnH+g6R+tOd1F+Au2XBnapGLSzVn6L/xPqgpyF4GxC BsbUzcuGv1OdH1fcE5Idi/uz9J87rLntH3Hc/o/aLakld8zzDYVFA0oM4a8N4Iq1SVBM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qOa0k-002L4n-O6; Wed, 26 Jul 2023 10:36:46 +0200 Date: Wed, 26 Jul 2023 10:36:46 +0200 From: Andrew Lunn To: Hayes Wang Cc: kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH net-next v2 1/2] r8152: adjust generic_ocp_write function Message-ID: References: <20230726030808.9093-417-nic_swsd@realtek.com> <20230726030808.9093-418-nic_swsd@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230726030808.9093-418-nic_swsd@realtek.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 26, 2023 at 11:08:07AM +0800, Hayes Wang wrote: > Reduce the control transfer if all bytes of first or the last DWORD are > written. > > The original method is to split the control transfer into three parts > (the first DWORD, middle continuous data, and the last DWORD). However, > they could be combined if whole bytes of the first DWORD or last DWORD > are written. That is, the first DWORD or the last DWORD could be combined > with the middle continuous data, if the byte_en is 0xff. How often is byte_en 0xff? Do you have some benchmark numbers to show it is worth the complexity? Andrew