mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aleksander Jan Bajkowski <olek2@wp.pl>
To: Andre Przywara <andre.przywara@arm.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: allwiner: h5: OrangePi PC2: add ethernet LEDs
Date: Mon, 28 Sep 2026 00:50:48 +0200	[thread overview]
Message-ID: <c643fc84-4f6d-4d69-8f22-4ca12a0fc125@wp.pl> (raw)
In-Reply-To: <20250909012422.43b755a4@minigeek.lan>

Hi Andre,
I see that my previous reply didn't reach lkml

On 09/09/2025 02:24, Andre Przywara wrote:
> On Mon, 18 Aug 2025 18:35:13 +0200
> Aleksander Jan Bajkowski <olek2@wp.pl> wrote:
>
>> This patch adds support for Ethernet LEDs.
> So I tried this on my OPi-PC2, but I cannot influence the LEDs. I have
> CONFIG_LED_TRIGGER_PHY and CONFIG_LEDS_TRIGGER_NETDEV built in, and I
> see mdio_mux-0.2:01:amber:lan and mdio_mux-0.2:01:green:lan in
> /sys/class/leds, but anything I write into trigger does not seem to
> change the output: it always stays on the network functionality, I
> guess because it's still configured to the PHY hardware wired function?
>
> What am I missing?
>
>

You should also set up the name of the device that controls the activity:

Example:
root@OpenWrt:/sys/class/leds/mdio_mux-0.2:01:green:lan# echo "eth0" > 
device_name
root@OpenWrt:/sys/class/leds/mdio_mux-0.2:01:green:lan# echo "1" > link_10
root@OpenWrt:/sys/class/leds/mdio_mux-0.2:01:green:lan# echo "1" > 
link_1000
root@OpenWrt:/sys/class/leds/mdio_mux-0.2:01:amber:lan# echo "eth0" > 
device_name
root@OpenWrt:/sys/class/leds/mdio_mux-0.2:01:amber:lan# echo "1" > rx
root@OpenWrt:/sys/class/leds/mdio_mux-0.2:01:amber:lan# echo "1" > tx


In the second iteration, I added the default-spate = “keep” property. By 
default,
the LEDs will be activated as before.

Regards,
Aleksander

      reply	other threads:[~2026-09-27 22:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18 16:35 Aleksander Jan Bajkowski
2025-09-08 14:45 ` Jernej Škrabec
     [not found]   ` <5617fd78-32aa-44f4-9f9c-16349b3f8450@wp.pl>
2025-09-08 22:57     ` Jernej Škrabec
2025-09-09  0:24 ` Andre Przywara
2026-09-27 22:50   ` Aleksander Jan Bajkowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c643fc84-4f6d-4d69-8f22-4ca12a0fc125@wp.pl \
    --to=olek2@wp.pl \
    --cc=andre.przywara@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®