From: Sagi Grimberg <sagi@grimberg.me>
To: Jaesoo Lee <jalee@purestorage.com>, nitzanc@mellanox.com
Cc: keith.busch@intel.com, axboe@fb.com, hch@lst.de,
Roland Dreier <roland@purestorage.com>,
Prabhath Sajeepa <psajeepa@purestorage.com>,
Ashish Karkare <ashishk@purestorage.com>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-rdma: complete requests from ->timeout
Date: Tue, 11 Dec 2018 15:38:57 -0800 [thread overview]
Message-ID: <c645f196-3fbb-c9b9-5686-730ceed102fa@grimberg.me> (raw)
In-Reply-To: <CAJX3Ctjtt2zebuLfzKM30PV1x3fm8HaJJFJw3zZSOShWnQnu=Q@mail.gmail.com>
> I cannot reproduce the bug with the patch; in my failure scenarios, it
> seems that completing the request on errors in nvme_rdma_send_done
> makes __nvme_submit_sync_cmd to be unblocked. Also, I think this is
> safe from the double completions.
>
> However, it seems that nvme_rdma_timeout code is still not free from
> the double completion problem. So, it looks promising to me if you
> could separate out the nvme_rdma_wr_error handling code as a new
> patch.
Guys, can you please send proper patches so we can review properly?
next prev parent reply other threads:[~2018-12-11 23:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 23:59 Jaesoo Lee
2018-11-30 1:30 ` Sagi Grimberg
2018-11-30 1:54 ` Jaesoo Lee
2018-12-07 0:18 ` Jaesoo Lee
2018-12-07 20:05 ` Sagi Grimberg
2018-12-08 2:02 ` Keith Busch
2018-12-08 6:28 ` Jaesoo Lee
2018-12-09 14:22 ` Nitzan Carmi
2018-12-10 23:40 ` Jaesoo Lee
2018-12-11 9:14 ` Nitzan Carmi
2018-12-11 23:16 ` Jaesoo Lee
2018-12-11 23:38 ` Sagi Grimberg [this message]
2018-12-12 1:31 ` Jaesoo Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c645f196-3fbb-c9b9-5686-730ceed102fa@grimberg.me \
--to=sagi@grimberg.me \
--cc=ashishk@purestorage.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=jalee@purestorage.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nitzanc@mellanox.com \
--cc=psajeepa@purestorage.com \
--cc=roland@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®