mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Randy Dunlap <randy.dunlap@oracle.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/4] printk: Don't allow direct inclusion
Date: Wed, 25 May 2011 10:02:40 -0700	[thread overview]
Message-ID: <c64c1617d99e4d0bb7b77ae9bfa0d80d80f4a765.1306342673.git.joe@perches.com> (raw)
In-Reply-To: <BANLkTimo30L7feKr9_Ec=fMoe1erw8Rnag@mail.gmail.com>
In-Reply-To: <cover.1306342673.git.joe@perches.com>

printk.h is a subfile of kernel.h, do not allow
it to be included directly.

Signed-off-by: Joe Perches <joe@perches.com>
---
 include/linux/printk.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/include/linux/printk.h b/include/linux/printk.h
index ee048e7..3736545 100644
--- a/include/linux/printk.h
+++ b/include/linux/printk.h
@@ -1,3 +1,7 @@
+#ifndef _LINUX_KERNEL_H
+#error "Do not include <linux/printk.h>, use <linux/kernel.h> instead"
+#endif
+
 #ifndef __KERNEL_PRINTK__
 #define __KERNEL_PRINTK__
 
-- 
1.7.4.rc3


  parent reply	other threads:[~2011-05-25 17:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-25  9:09 [PATCH 1/4] include/linux/printk.h is not self-contained y
2011-05-25 14:42 ` Joe Perches
2011-05-25 15:20   ` Geert Uytterhoeven
2011-05-25 15:52     ` Alexey Dobriyan
2011-05-25 17:02     ` [PATCH 0/4] printk: cleanups of direct includes Joe Perches
2011-05-25 17:02       ` [PATCH 1/4] treewide: Remove direct includes of printk.h Joe Perches
2011-05-25 17:02       ` [PATCH 2/4] staging: " Joe Perches
2011-05-26  7:37         ` Roland Vossen
2011-05-29 17:00         ` julie Sullivan
2011-05-29 20:40           ` Joe Perches
2011-05-25 17:02       ` Joe Perches [this message]
2011-05-25 17:02       ` [PATCH 4/4] treewide: Remove asmlinkage from printk Joe Perches
2011-05-25 17:09 ` [PATCH 1/4] include/linux/printk.h is not self-contained Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c64c1617d99e4d0bb7b77ae9bfa0d80d80f4a765.1306342673.git.joe@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®