From: Kory Maincent <kory.maincent@bootlin.com>
To: Carlo Szelinsky <github@szelinsky.de>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Corey Leavitt <corey@leavitt.info>,
Kyle Swenson <kyle.swenson@est.tech>,
Simon Horman <horms@kernel.org>,
netdev-bot+sashiko@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/4] net: pse-pd: core fixes ahead of the controller notifier
Date: Mon, 19 Oct 2026 14:54:12 +0200 [thread overview]
Message-ID: <c652ce20-a3c7-432b-8bd1-dac902f04149@bootlin.com> (raw)
In-Reply-To: <20261018081853.47484-1-github@szelinsky.de>
On 10/18/26 10:18, Carlo Szelinsky wrote:
> These four PSE core fixes were part of the "decouple controller lookup
> from MDIO probe" series [1]; Oleksij asked to split them out. They do
> not need phylib, and each one fixes a problem on its own:
>
> 1. Unregister frees the PI data while the controller can still be
> found. Take it off the list and stop the IRQ and the worker first.
> 2. A failed registration leaks memory, and can leave freed power
> domains in the global map. Clean up on the error paths.
> 3. si3474: use dev_err_probe(), so the deferral from 4 is not logged
> as an error.
> 4. Defer the PSE driver's probe until every PI's vpwr supply is there.
>
> Patch 1 conflicts with the pending net series [2]; keep the order from
> patch 1. Patch 2 conflicts with two of the net fixes posted alongside
> [3]; the note below its --- explains how to merge them.
>
> Tested in QEMU on arm64 with KASAN, lockdep and kmemleak: controllers
> whose supply never appears defer, and an injected pse_register_pw_ds()
> failure is cleaned up and retried. The only KASAN reports are the known
> stale-handle bug at MDIO bus unbind, the same without this series; the
> decouple series fixes it. This series, the decouple series and the net
> fixes together also run on a Hasivo S600WP (hs104), with 200 controller
> unbind/bind cycles and no warnings or leaks. Every patch builds with
> W=1, and PHYLIB=m, PHYLIB=n and PSE_CONTROLLER=n link.
These are fixes, please send them to net instead.
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-10-19 12:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 8:18 Carlo Szelinsky
2026-10-18 8:18 ` [PATCH net-next 1/4] net: pse-pd: unlink the controller before freeing its PI data Carlo Szelinsky
2026-10-19 8:35 ` netdev-bot+sashiko
2026-10-19 19:56 ` Carlo Szelinsky
2026-10-18 8:18 ` [PATCH net-next 2/4] net: pse-pd: unwind allocations when controller registration fails Carlo Szelinsky
2026-10-19 8:35 ` netdev-bot+sashiko
2026-10-19 19:56 ` Carlo Szelinsky
2026-10-18 8:18 ` [PATCH net-next 3/4] net: pse-pd: si3474: use dev_err_probe() for controller registration Carlo Szelinsky
2026-10-18 8:18 ` [PATCH net-next 4/4] net: pse-pd: check the PI vpwr supply before registering the controller Carlo Szelinsky
2026-10-19 8:35 ` netdev-bot+sashiko
2026-10-19 19:56 ` Carlo Szelinsky
2026-10-18 8:23 ` [PATCH net-next 0/4] net: pse-pd: core fixes ahead of the controller notifier netdev-bot+sinfo
2026-10-19 19:56 ` Carlo Szelinsky
2026-10-19 12:54 ` Kory Maincent [this message]
2026-10-19 19:55 ` Carlo Szelinsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c652ce20-a3c7-432b-8bd1-dac902f04149@bootlin.com \
--to=kory.maincent@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=broonie@kernel.org \
--cc=corey@leavitt.info \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=github@szelinsky.de \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kyle.swenson@est.tech \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®