mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>,
	"Richard Cochran" <richardcochran@gmail.com>,
	"Andrew Lunn" <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Yangbo Lu" <yangbo.lu@nxp.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	cheung wall <zzqq0103.hey@gmail.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH net] ptp: limit number of virtual clocks per physical clock
Date: Tue, 7 Jan 2025 13:04:02 +0100	[thread overview]
Message-ID: <c6547053-7de2-42a2-b8f7-6837e9ab85ca@redhat.com> (raw)
In-Reply-To: <20250103-ptp-max_vclocks-v1-1-2406b8eade97@weissschuh.net>

On 1/3/25 2:40 PM, Thomas Weißschuh wrote:
> The sysfs interface can be used to trigger arbitrarily large memory
> allocations. This can induce pressure on the VM layer to satisfy the
> request only to fail anyways.
> 
> Reported-by: cheung wall <zzqq0103.hey@gmail.com>
> Closes: https://lore.kernel.org/lkml/20250103091906.GD1977892@ZenIV/
> Fixes: 73f37068d540 ("ptp: support ptp physical/virtual clocks conversion")
> Cc: stable@vger.kernel.org
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> The limit is completely made up, let me know if there is something
> better.

I'm also unsure if such constant value is reasonable for all the
use-cases. Any additional feedback more than welcome.

In any case, I guess it would make sense to update
Documentation/ABI/testing/sysfs-ptp accordingly.

Thanks,

Paolo


      reply	other threads:[~2025-01-07 12:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-03 13:40 Thomas Weißschuh
2025-01-07 12:04 ` Paolo Abeni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6547053-7de2-42a2-b8f7-6837e9ab85ca@redhat.com \
    --to=pabeni@redhat.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yangbo.lu@nxp.com \
    --cc=zzqq0103.hey@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®