From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CA10C77B76 for ; Sun, 16 Apr 2023 09:53:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230400AbjDPJxf (ORCPT ); Sun, 16 Apr 2023 05:53:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230164AbjDPJxb (ORCPT ); Sun, 16 Apr 2023 05:53:31 -0400 Received: from sender3-op-o18.zoho.com (sender3-op-o18.zoho.com [136.143.184.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D894AE62; Sun, 16 Apr 2023 02:53:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681638761; cv=none; d=zohomail.com; s=zohoarc; b=E0swol1jw29yr7sbkD56kf0SXwk+LNzYdYTwvIMMhagyxm0z6vxHQZoLvxwjAjISMrIEc7XWnhviPfJy7EZOZ3lVAowfmmjdTC27FwHtQFGqQGLUkCQXXFQK84B5Nl8iAQOvy0gU1MgfZa+pogwdHLx6GaZXpUjoxH18kREFcQk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681638761; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=GCZjhm4Hbh1Xe4YSlI4A2hA8xi0IlyPYCkMgUVWDgKg=; b=abx6MaJDAXNiOU77CW+9MuEOVWOjcOjjS5/G6GwxWQN161hmmK0YoEgZpSc8mASh5p3ken7rBFBGz9OYGYGnl+yUldoERi+r+S+/oW/eFtkSu7rvFbcMCcpTw7hBdZ7wicNTcIU0TvEYTDFtZh8vR1dzxHA2s03v+cTnkH9l3rA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=arinc9.com; spf=pass smtp.mailfrom=arinc.unal@arinc9.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1681638761; s=zmail; d=arinc9.com; i=arinc.unal@arinc9.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=GCZjhm4Hbh1Xe4YSlI4A2hA8xi0IlyPYCkMgUVWDgKg=; b=GMZ9Mi9oXvS+IUd1T5GR+csOJt5VeL93w9TXXeG4IGa1BF0s/Jb9eHL/irN5fYOY a3+qZQeGd89KFxbYrY74lLcGEAzxrwGy8A5tauSRwex33XtR2UunlWHUupWsz1zTMEu pEFdBN9lTQ5L9q2MJoxBbmKFMGgd45zDVXG4t+1E= Received: from [10.10.10.3] (149.91.1.15 [149.91.1.15]) by mx.zohomail.com with SMTPS id 1681638759506996.2741470788767; Sun, 16 Apr 2023 02:52:39 -0700 (PDT) Message-ID: Date: Sun, 16 Apr 2023 12:52:31 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RFC/RFT v1] net: ethernet: mtk_eth_soc: drop generic vlan rx offload, only use DSA untagging Content-Language: en-US To: Frank Wunderlich , Felix Fietkau , Vladimir Oltean , Daniel Golle Cc: John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Frank Wunderlich References: <20230416091038.54479-1-linux@fw-web.de> From: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= In-Reply-To: <20230416091038.54479-1-linux@fw-web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16.04.2023 12:10, Frank Wunderlich wrote: > From: Felix Fietkau > > Through testing I found out that hardware vlan rx offload support seems to > have some hardware issues. At least when using multiple MACs and when receiving > tagged packets on the secondary MAC, the hardware can sometimes start to emit > wrong tags on the first MAC as well. > > In order to avoid such issues, drop the feature configuration and use the > offload feature only for DSA hardware untagging on MT7621/MT7622 devices which > only use one MAC. MT7621 devices most certainly use both MACs. > > Tested-by: Frank Wunderlich > Signed-off-by: Felix Fietkau > Signed-off-by: Frank Wunderlich > --- > used felix Patch as base and ported up to 6.3-rc6 which seems to get lost > and the original bug is not handled again. > > it reverts changes from vladimirs patch > > 1a3245fe0cf8 net: ethernet: mtk_eth_soc: fix DSA TX tag hwaccel for switch port 0 Do I understand correctly that this is considered being reverted because the feature it fixes is being removed? Arınç