From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753817AbdJPPFa (ORCPT ); Mon, 16 Oct 2017 11:05:30 -0400 Received: from mout.web.de ([212.227.17.12]:62239 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753308AbdJPPF1 (ORCPT ); Mon, 16 Oct 2017 11:05:27 -0400 Subject: [PATCH 2/4] char/snsc: Delete three error messages for a failed memory allocation From: SF Markus Elfring To: kernel-janitors@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman Cc: LKML References: Message-ID: Date: Mon, 16 Oct 2017 17:05:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:IinEEEa5DaDXIHQbdA9BVK7HmzhHmXTYj5+oP1rTLKOaFX2oy3Q 6RoMLpG9b7mmvD/DATe1P3IboDhbHSDj86KSvUCMnjVHPf53IbTrCJGI4siJD41WCKrSPoh gkNOaJR9FjxmUZUkX9zTkzkEjYX4cR4XdJOd7FxAwmJ72Q/SHBywyE4VVFEBYcC6RbjkDhr MEkgU6zZAggUVL1t9JvCA== X-UI-Out-Filterresults: notjunk:1;V01:K0:JbjP7evdZp0=:SYtoJxeViYw5wKt+dPoVOx iAA1z28pN0tywikbCVZAn/ehaknio420cUM4muDeim70JdgUmaCOb65HNOXX98N02v1794GAq MD+ahQmcGio6M137FsrWLCM/eKtoMbXAF/CaxXp8hqK0qhEOI6VCJDPoH9azpQ9WDPORtKw99 cPhCfxRlDTtWOiAKGu4LkDJ8GGzdQH/OglY4Ooi0JWXHoQBY7mtEMbxuigXKn1qmxwNKiLnpf 7B6546Xz0IvF2RnvjRX6YDu6egGSUJlmITJdDlmm4rg89ENyYcRW9ZSrRZ0mX41+iugNkTeDO lnK3P+YY0W6LSFI5p/vzBi7bQb37a6Sdh4IJeqzZDvFUzOZjbNGqQ+K9pcGR8T802f43TNktl +aMZob//1p+MnASLVpOGmpHHiABc/C8QNFf3kvcoiavfnN6hf/+2DxsNzikTPgWXdvbSs6z8S eC8ixo9CFb2yzzOGNCu8LXBYPgk9xsw6o31WcfwMPzjW1mFUNtRwGRFn3IJbIRZ8o7FgxJ+Xk FVVWL1uFJmVACjioReCkxtmqKpMqLiGQflYVvMWuHTEaXJAryMO3UrDjoHsFVHXpGLEqA0vsn YLF7psfABD8zfnY2LT3wb2rV92poFW5BCEEzbLoxAojSNPwx2fDfoe9Ngk7BGTNFYnc+LGqtG b+0CroCiEow4S1DHVF7kq+BLzDvp4B0U2Q4UcpcTbiCF9PHlSM2+mRKIf8i+XvcM1iw/eFzUM Pmw8DK+ub9HXBNQOGqdGPpPhR6c1GK1BeRR82IELJV1T3RrwiiRHAylj0bCZ3xFpccu+Bf5lE cesAzQUx2/pc6FGKjDFANSOrWppqPRdicmwY3MjCKQMi164KFY= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 16 Oct 2017 16:24:09 +0200 Omit extra messages for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/char/snsc.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/char/snsc.c b/drivers/char/snsc.c index f551a625686a..eefc306033ab 100644 --- a/drivers/char/snsc.c +++ b/drivers/char/snsc.c @@ -80,11 +80,8 @@ scdrv_open(struct inode *inode, struct file *file) /* allocate memory for subchannel data */ sd = kzalloc(sizeof (struct subch_data_s), GFP_KERNEL); - if (sd == NULL) { - printk("%s: couldn't allocate subchannel data\n", - __func__); + if (!sd) return -ENOMEM; - } /* initialize subch_data_s fields */ sd->sd_nasid = scd->scd_nasid; @@ -410,20 +407,13 @@ scdrv_init(void) /* allocate sysctl device data */ scd = kzalloc(sizeof (struct sysctl_data_s), GFP_KERNEL); - if (!scd) { - printk("%s: failed to allocate device info" - "for %s/%s\n", __func__, - SYSCTL_BASENAME, devname); + if (!scd) continue; - } /* initialize sysctl device data fields */ scd->scd_nasid = cnodeid_to_nasid(cnode); salbuf = kmalloc(SCDRV_BUFSZ, GFP_KERNEL); if (!salbuf) { - printk("%s: failed to allocate driver buffer" - "(%s%s)\n", __func__, - SYSCTL_BASENAME, devname); kfree(scd); continue; } -- 2.14.2