Re: [PATCH v3 4/7] media: qcom: camss: enable csid 690 for qcs8300

[Vikram Sharma <quic_vikramsa@quicinc.com>]

On 8/14/2025 3:03 AM, Bryan O'Donoghue wrote:
> On 13/08/2025 06:37, Vikram Sharma wrote:
>> The CSID in qcs8300 is version 690, it is same as csid used in
>> lemans(sa8775p). csid gen3 have support for csid 690.
>>
>> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
>> ---
>>   drivers/media/platform/qcom/camss/camss-csid-gen3.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/qcom/camss/camss-csid-gen3.c 
>> b/drivers/media/platform/qcom/camss/camss-csid-gen3.c
>> index fc6a9787febe..664245cf6eb0 100644
>> --- a/drivers/media/platform/qcom/camss/camss-csid-gen3.c
>> +++ b/drivers/media/platform/qcom/camss/camss-csid-gen3.c
>> @@ -45,7 +45,8 @@
>>   #define CSID_CSI2_RX_IRQ_CLEAR        0xA4
>>   #define CSID_CSI2_RX_IRQ_SET        0xA8
>>   -#define IS_CSID_690(csid) (csid->camss->res->version == CAMSS_8775P)
>> +#define IS_CSID_690(csid) ((csid->camss->res->version == CAMSS_8775P) \
>> +                 || (csid->camss->res->version == CAMSS_8300))
>>   #define CSID_BUF_DONE_IRQ_STATUS    0x8C
>>   #define BUF_DONE_IRQ_STATUS_RDI_OFFSET  (csid_is_lite(csid) ?\
>>                           1 : (IS_CSID_690(csid) ?\
>
> This really feels like it should be a property of the CSID not of the 
> SoC but... anyway it'll do for now.

Hi Bryan,

Thanks for your review. I will address this in a follow up series 
marking dependency on this one.


>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

Regards,
Vikram