From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58194C433EF for ; Sun, 17 Oct 2021 12:18:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2743E60FD9 for ; Sun, 17 Oct 2021 12:18:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245631AbhJQMUo (ORCPT ); Sun, 17 Oct 2021 08:20:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236377AbhJQMUn (ORCPT ); Sun, 17 Oct 2021 08:20:43 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CF3EC061765 for ; Sun, 17 Oct 2021 05:18:33 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id i12so35682289wrb.7 for ; Sun, 17 Oct 2021 05:18:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=7DhS3xtuHzWs9QFl24FwJLyWw4/xQqInsj4QCIIJh1M=; b=hfqh5imm8xBcObv8zzNvDJf0CPixtc+OiYm7Pmulk2GUF73IcUMg8bCyRAWwQfqVeC cBmyZs5v8w+Xo8UmL8nrCgIxNRBntW+MMthZ4lPq/Au0lg1SebjM6pBW7I9ydeEUoe7j PEeRaAl97ndUEshNHBejYMWAtpw21IdsqAxGg11AW07D5LCShV5nnx2Q1wtpJdCEmngN TLHpA1fvJbMdcW+Yghp/riRGRwLXqFAxESeNE5TcP2IBQSvpUf6MIYQR4vS8w1xawCBQ P77llcvI1y5cBdtL/SAOf6G9Xsf8wZVJ3LloHgSfAsRr+2xCMKYDIiwgj4EnvQOeOvV6 YfZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=7DhS3xtuHzWs9QFl24FwJLyWw4/xQqInsj4QCIIJh1M=; b=4MnReIfrwJlRQLFk/GB8g2VdsWBFEZWVZQ6xQ4p/7xx9UjU8ehZIQwFYMiEWEUrnYq ZFqLyd1FWdRpq2tVhwBuZqgyAv6TlcWlgq5UcjAN3/5q245KNVt80a9c8wAoSUKkiLAy sb8Fazo7B/pvNNqkHGMp5dgjOyoB09GjY6GlxZPkTjNTPKdKw1qFozYq5Gf4ZuIh+nag C6BXGTrc09bmxdpoHcg2pPRdsR/bg8UeybAYmbJHD875gCcGnNV8/0eIkImdBpIwPZSs Uyd9MpFHqnGK+xIqH5EdehObim0N96JirZrHBY6cEb8mGE0jK8Pd2Rh4buHDMxFjJnt1 gkCQ== X-Gm-Message-State: AOAM5306SQTD3hmmr7U9niChILLxPGtR6PRfUdhJ/YU8MkrU659Ucx45 rRlzfUcLc/Z/DSzt+wThO68= X-Google-Smtp-Source: ABdhPJzvF+3lwjBeblRFndrqh1FPhC4J83Ycrrcf7GJLrnmvnfaXZiANaC7NSmEa2O01+MTfvQd63Q== X-Received: by 2002:adf:bb08:: with SMTP id r8mr29415642wrg.247.1634473112164; Sun, 17 Oct 2021 05:18:32 -0700 (PDT) Received: from ?IPV6:2a02:8108:96c0:3b88::d7f0? ([2a02:8108:96c0:3b88::d7f0]) by smtp.gmail.com with ESMTPSA id i203sm12329666wma.48.2021.10.17.05.18.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Oct 2021 05:18:31 -0700 (PDT) Message-ID: Date: Sun, 17 Oct 2021 14:18:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 2/3] staging: r8188eu: Makefile: don't overwrite global settings Content-Language: en-US To: Martin Kaiser , Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20211016173544.25376-1-martin@kaiser.cx> <20211016173544.25376-3-martin@kaiser.cx> From: Michael Straube In-Reply-To: <20211016173544.25376-3-martin@kaiser.cx> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/21 19:35, Martin Kaiser wrote: > Remove settings from the Makefile that are set by higher-level Makefiles. > > Some of those settings might have been useful when the driver was > maintained out of tree. > > Signed-off-by: Martin Kaiser > --- > drivers/staging/r8188eu/Makefile | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/drivers/staging/r8188eu/Makefile b/drivers/staging/r8188eu/Makefile > index fccf7e6d1520..8294fb69ecf9 100644 > --- a/drivers/staging/r8188eu/Makefile > +++ b/drivers/staging/r8188eu/Makefile > @@ -1,8 +1,3 @@ > -SHELL := /bin/bash > -EXTRA_CFLAGS += $(USER_EXTRA_CFLAGS) > -EXTRA_CFLAGS += -O1 > - > -ccflags-y += -D__CHECK_ENDIAN__ > > OUTSRC_FILES := \ > hal/HalHWImg8188E_MAC.o \ > @@ -46,15 +41,6 @@ _OS_INTFS_FILES := \ > > _HAL_INTFS_FILES += $(OUTSRC_FILES) > > -SUBARCH := $(shell uname -m | sed -e "s/i.86/i386/; s/ppc.*/powerpc/; s/armv.l/arm/; s/aarch64/arm64/;") > - > -ARCH ?= $(SUBARCH) > -CROSS_COMPILE ?= > -KVER ?= $(if $(KERNELRELEASE),$(KERNELRELEASE),$(shell uname -r)) > -KSRC ?= $(if $(KERNEL_SRC),$(KERNEL_SRC),/lib/modules/$(KVER)/build) > -MODDESTDIR := /lib/modules/$(KVER)/kernel/drivers/net/wireless > -INSTALL_PREFIX := > - > rtk_core := \ > core/rtw_ap.o \ > core/rtw_br_ext.o \ > Hi Martin, this patch introduces a GCC warning on my system. drivers/staging/r8188eu/os_dep/ioctl_linux.c: In function 'rtw_wx_set_enc_ext': drivers/staging/r8188eu/os_dep/ioctl_linux.c:1929:9: warning: 'strncpy' specified bound 16 equals destination size [-Wstringop-truncation] 1929 | strncpy((char *)param->u.crypt.alg, alg_name, IEEE_CRYPT_ALG_NAME_LEN); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Regards, Michael