From: Romain Porte <romain.porte@nokia.com>
To: cyrille.pitchen@wedev4u.fr
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
alexander.sverdlin@nokia.com, pascal.fabreges@nokia.com
Subject: Re: [PATCH v2] mtd: spi-nor: Added ISSI is25lp080d support
Date: Wed, 27 Dec 2017 15:46:37 +0100 [thread overview]
Message-ID: <c668b55b-f35e-cdfd-1f90-dc1289a73b40@nokia.com> (raw)
In-Reply-To: <20171227135809.2407-1-romain.porte@nokia.com>
On 27/12/2017 14:58, Romain Porte wrote:
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 8bafd462f..18e826d36 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1050,6 +1050,8 @@ static const struct flash_info spi_nor_ids[] = {
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "is25lp128", INFO(0x9d6018, 0, 64 * 1024, 256,
> SECT_4K | SPI_NOR_DUAL_READ) },
> + { "is25lp080d", INFO(0x9d6014, 0, 64 * 1024, 16,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>
Please note that the new SPI_NOR_DUAL_READ and SPI_NOR_QUAD_READ options
have not been tested on our hardware for the moment. The Tested-by flag
applies only for the previous configuration without these two new flags.
We may be able to test these additional flags in the future, but they
were added only from your (Cyrille's) review from previous patch.
Please let me know if you want to wait for our hardware test results
before merging into spi-nor/next, or if you are confident enough to
merge it as this.
Romain.
next prev parent reply other threads:[~2017-12-27 14:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 13:43 [PATCH] " Romain Porte
2017-12-19 15:27 ` Cyrille Pitchen
2017-12-27 13:58 ` [PATCH v2] " Romain Porte
2017-12-27 14:46 ` Romain Porte [this message]
2017-12-27 20:28 ` Cyrille Pitchen
2017-12-28 10:03 ` [PATCH v3] mtd: spi-nor: Add " Romain Porte
2017-12-28 11:21 ` Cyrille Pitchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c668b55b-f35e-cdfd-1f90-dc1289a73b40@nokia.com \
--to=romain.porte@nokia.com \
--cc=alexander.sverdlin@nokia.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=pascal.fabreges@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®