From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49647C61DA4 for ; Sat, 11 Mar 2023 12:30:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229835AbjCKMaR (ORCPT ); Sat, 11 Mar 2023 07:30:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230300AbjCKMaN (ORCPT ); Sat, 11 Mar 2023 07:30:13 -0500 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4F2112DDCD for ; Sat, 11 Mar 2023 04:30:03 -0800 (PST) Received: by mail-ed1-x530.google.com with SMTP id k10so31059952edk.13 for ; Sat, 11 Mar 2023 04:30:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678537802; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yjUhnHyDUJ5wg8HgLp7R2j6/UQh7qFkqjXC6cud7wFA=; b=NaF5Ipx6n2Sl2HxZZipEbRVnt/v/6N6IYCoCCu4OCVg0HDbVKNyh59h6wCsPqL84/Z lN1aKk4uVw2tADThdJierZuVSbNSkZmwQ4Fc8CcGB+xPoJACaROQCXFFAWlVa9Q88zfQ lv82QDWfIUpvDa+GftxlBRqJ93GQeO+RQUsMSc5i7hBHnTgcCJ3EzrvCKRHHTc4IceXP ViCn1Jldd51NbX2laUXcbEkeuQZHP9G1oo0KmKAFObwmozQG219jMaP0S3bBj6oJ3lHo wD9Bnp29yZJAj1HcDhDDtNI0VWtMxsgLPzNXS0xjHWsn3PTOnV/e72eCa3tB3qmuodMz HqAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678537802; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yjUhnHyDUJ5wg8HgLp7R2j6/UQh7qFkqjXC6cud7wFA=; b=NM8JAmA4TQnyVjRtkKGjY6ZU9y/swcBiuECCEe2NfCZzYT8Qt06wV89Smxn1HTmhl3 mX7v5or5my/BmL315evWkkN5LjRJ2Fn74z1M0yw6faVD0kmPOvjNyR6PAInNrk/VadWc vcnTwnEcSD2U/QEMaJ7i8Qw5ydGsOMMalIhLxpcunAxU6NfQ+o3VfrNl3LGcEQoT/HMl d/jHMZoLlJG+B59XAJUo5bL8TjdOikGgvuOAxB19q+cTTl1Vji7WF3Oh4pxayBWqfzrC NZTIpzavyxRKOOwOwJGCrEkceqZRsLhntz1/c3JOgvi3m6NAAaXh/uw5djo2NNrDIYdn nsbQ== X-Gm-Message-State: AO0yUKUh1syEpWHTvdP1q5v+8uEESSOoGA/v57sMtNbxSuVbXhB2xrdo MJeuI0qTKmwsJrVwstG6zWR0Gg== X-Google-Smtp-Source: AK7set/2o8ivcKMwc0mQHra9eJumNEYv6mhH+0exAy0texGLIvUhlh2ftWQaJ8F01uSG1mo/Mr5EtA== X-Received: by 2002:a17:907:ca85:b0:922:3a53:46f8 with SMTP id ul5-20020a170907ca8500b009223a5346f8mr882715ejc.64.1678537802201; Sat, 11 Mar 2023 04:30:02 -0800 (PST) Received: from ?IPV6:2a02:810d:15c0:828:fa97:2d7c:bdd7:e1b? ([2a02:810d:15c0:828:fa97:2d7c:bdd7:e1b]) by smtp.gmail.com with ESMTPSA id jg30-20020a170907971e00b0091ec885e016sm1030730ejc.54.2023.03.11.04.30.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Mar 2023 04:30:01 -0800 (PST) Message-ID: Date: Sat, 11 Mar 2023 13:30:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 4/4] iio: proximity: sx9500: Mark ACPI and OF related data as maybe unused Content-Language: en-US To: Jonathan Cameron Cc: Marek Vasut , Lars-Peter Clausen , Michael Hennerich , Robert Eshleman , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230311111457.251475-1-krzysztof.kozlowski@linaro.org> <20230311111457.251475-4-krzysztof.kozlowski@linaro.org> <20230311122833.03b5a3d7@jic23-huawei> From: Krzysztof Kozlowski In-Reply-To: <20230311122833.03b5a3d7@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/03/2023 13:28, Jonathan Cameron wrote: > On Sat, 11 Mar 2023 12:14:57 +0100 > Krzysztof Kozlowski wrote: > >> The driver can be compile tested with !CONFIG_OF or !CONFIG_ACPI making >> certain data unused: >> >> drivers/iio/proximity/sx9500.c:1039:34: error: ‘sx9500_of_match’ defined but not used [-Werror=unused-const-variable=] >> >> Signed-off-by: Krzysztof Kozlowski > > Hi Krysztof > > Thanks for looking at these warnings. > > Drop the protection macros instead. The tables are trivial in size and > the of_match_ptr() breaks some ways this driver can be used. > ACPI_PTR() isn't as bad, but is pretty much pointless given this size of > the array. > For ACPI platform, ACPI table is used, so nothing for PRP0001. For OF platform, OF table is used. What usage exactly is broken here? What ways? Best regards, Krzysztof