From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756213AbdEDTNa (ORCPT ); Thu, 4 May 2017 15:13:30 -0400 Received: from mail-eopbgr30068.outbound.protection.outlook.com ([40.107.3.68]:15597 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753018AbdEDTNV (ORCPT ); Thu, 4 May 2017 15:13:21 -0400 From: Han Xu To: Stefan Agner , "dwmw2@infradead.org" , "computersforpeace@gmail.com" , "boris.brezillon@free-electrons.com" , "marek.vasut@gmail.com" , "richard@nod.at" , "cyrille.pitchen@atmel.com" CC: "robh+dt@kernel.org" , "mark.rutland@arm.com" , "shawnguo@kernel.org" , "kernel@pengutronix.de" , "fabio.estevam@freescale.com" , "LW@KARO-electronics.de" , "linux-mtd@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 4/5] ARM: dts: imx7: add GPMI NAND Thread-Topic: [PATCH v2 4/5] ARM: dts: imx7: add GPMI NAND Thread-Index: AQHSuwbg2fq7XKu++UG1x4fvXWlJy6HkngyA Date: Thu, 4 May 2017 19:13:16 +0000 Message-ID: References: <20170422012338.4635-1-stefan@agner.ch> <20170422012338.4635-5-stefan@agner.ch> In-Reply-To: <20170422012338.4635-5-stefan@agner.ch> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=han.xu@nxp.com; x-originating-ip: [192.88.168.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DBXPR04MB078;7:PlTaYXcoe92wZam2SnEKS7AMx879sMxMDfJm7xaoR8uj0edA4U8XwoVk9nc0fyZZ9/OnTlMHRf25mxJ+Qd28mnw9aU7hKk4j/oaSDXPjEM0Wu8LLBwHdygwwFhhN2Y1Ep3cfP7MjemJ3xzVSaVbUKcl7gYTCzghLbaJYdiGdpxoMKHXLwC7dJM0TbXoyQNAh53aoBajomsNfFR8n7AmChQMXUcIYxWGxq0FZWF2+1srlndradQOTfPsay6FnOFlUwwuFc9mU2oT3AXVDxyLp77PfVcOp9rcYbSbmW+cyujKoCq3kGZSlOjXRS9xAbZzPwzWsfPKk5D9QpZhq2IT1/Q== x-ms-office365-filtering-correlation-id: 9578e7d9-6e43-466d-e46b-08d493219e70 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:DBXPR04MB078; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123562025)(6072148);SRVR:DBXPR04MB078;BCL:0;PCL:0;RULEID:;SRVR:DBXPR04MB078; x-forefront-prvs: 02973C87BC x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39840400002)(39450400003)(39860400002)(39400400002)(39850400002)(39410400002)(377454003)(24454002)(31686004)(3280700002)(76176999)(54356999)(50986999)(2950100002)(3660700001)(53936002)(2900100001)(36756003)(7736002)(6512007)(6306002)(99286003)(54906002)(305945005)(478600001)(189998001)(6246003)(38730400002)(31696002)(4326008)(2201001)(5660300001)(33646002)(6486002)(6436002)(6506006)(7416002)(25786009)(81166006)(39060400002)(53546009)(66066001)(5250100002)(2501003)(229853002)(102836003)(6116002)(8936002)(3846002)(8676002)(86362001)(2906002);DIR:OUT;SFP:1101;SCL:1;SRVR:DBXPR04MB078;H:DBXPR04MB080.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="Windows-1252" Content-ID: <4865F377CEBB87448E2D391CA8CA02FE@eurprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2017 19:13:16.6575 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR04MB078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v44JDqp4021084 On 04/21/2017 08:23 PM, Stefan Agner wrote: > Add i.MX 7 GPMI NAND module. > > Signed-off-by: Stefan Agner > --- > arch/arm/boot/dts/imx7s.dtsi | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi > index 843eb379e1ea..9645257638d4 100644 > --- a/arch/arm/boot/dts/imx7s.dtsi > +++ b/arch/arm/boot/dts/imx7s.dtsi > @@ -995,5 +995,36 @@ > status = "disabled"; > }; > }; > + > + dma_apbh: dma-apbh@33000000 { > + compatible = "fsl,imx7d-dma-apbh", "fsl,imx28-dma-apbh"; > + reg = <0x33000000 0x2000>; > + interrupts = , > + , > + , > + ; > + interrupt-names = "gpmi0", "gpmi1", "gpmi2", "gpmi3"; > + #dma-cells = <1>; > + dma-channels = <4>; > + clocks = <&clks IMX7D_NAND_USDHC_BUS_ROOT_CLK>, > + <&clks IMX7D_NAND_ROOT_CLK>; > + clock-names = "dma_apbh_bch", "dma_apbh_io"; > + }; Do you need some patches to enable all clks for APBH DMA? Refer to https://patchwork.ozlabs.org/patch/551967/ > + > + gpmi: gpmi-nand@33002000{ > + compatible = "fsl,imx7d-gpmi-nand"; > + #address-cells = <1>; > + #size-cells = <1>; > + reg = <0x33002000 0x2000>, <0x33004000 0x4000>; > + reg-names = "gpmi-nand", "bch"; > + interrupts = ; > + interrupt-names = "bch"; > + clocks = <&clks IMX7D_NAND_ROOT_CLK>, > + <&clks IMX7D_NAND_USDHC_BUS_ROOT_CLK>; > + clock-names = "gpmi_io", "gpmi_bch_apb"; > + dmas = <&dma_apbh 0>; > + dma-names = "rx-tx"; > + status = "disabled"; > + }; > }; > };