From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CD76C25B6B for ; Tue, 24 Oct 2023 02:51:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232408AbjJXCvH (ORCPT ); Mon, 23 Oct 2023 22:51:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232371AbjJXCvF (ORCPT ); Mon, 23 Oct 2023 22:51:05 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 170BE10A; Mon, 23 Oct 2023 19:50:59 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DB15C433C7; Tue, 24 Oct 2023 02:50:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698115858; bh=ECr5ZJxdFFyYc11ubfZSs54qOOUCIcaZ7LR/5g5OzUQ=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=cgw613z2rQFqTj8u9QjDMQCOA5in+b3q/5FTcamjTg/UCWbpCYzFcYJeclK5mcg0l EC1v98hT6UHw0SND4LyCUlSXqrF3xSvbNR0aBUb3VBZrrnt6R8bRsVhcXtVAt8aIMB XkwzaFBzoyA3g2KR1p4IoXReFjsbWIsG8/+o0x0QDGt1lrw1CTLb+hVX8s8VUy+ry8 G3b4Dsy7m7Do6fVYAW3SyBRldrBKWeIi2guxxwAeDLNprBW3IblGgJPEpslE9bViBY IgvhdCWPupt0vLMgNZi/MsKpUXu0Hnw2Bi8OHWj8Ab2mLOOWA+Z4wTLF6MiXydtW6z 3FcO/gsUKC2mA== Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230915-ep93xx-v4-4-a1d779dcec10@maquefel.me> References: <20230915-ep93xx-v4-0-a1d779dcec10@maquefel.me> <20230915-ep93xx-v4-4-a1d779dcec10@maquefel.me> Subject: Re: [PATCH v4 04/42] clk: ep93xx: add DT support for Cirrus EP93xx From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Arnd Bergmann , Alexander Sverdlin To: Michael Turquette , Nikita Shubin via B4 Relay , nikita.shubin@maquefel.me Date: Mon, 23 Oct 2023 19:50:56 -0700 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Nikita Shubin via B4 Relay (2023-09-15 01:10:46) > diff --git a/drivers/clk/clk-ep93xx.c b/drivers/clk/clk-ep93xx.c > new file mode 100644 > index 000000000000..e8d3bd595255 > --- /dev/null > +++ b/drivers/clk/clk-ep93xx.c > @@ -0,0 +1,753 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* > + * Clock control for Cirrus EP93xx chips. [...] > +#define EP93XX_SYSCON_KEYTCHCLKDIV_KEN 15 > +#define EP93XX_SYSCON_KEYTCHCLKDIV_KDIV 0 > +#define EP93XX_SYSCON_CHIPID 0x94 > +#define EP93XX_SYSCON_CHIPID_ID 0x9213 > + > +static const char adc_divisors[] =3D { 16, 4 }; > +static const char sclk_divisors[] =3D { 2, 4 }; > +static const char lrclk_divisors[] =3D { 32, 64, 128 }; > + > +static const struct clk_parent_data ep93xx_clk_parents[] =3D { > + { .fw_name =3D "xtali", .name =3D "xtali" }, Drop name. And please drop fw_name too and set .index to 0 explicitly. > + { .index =3D -1, .name =3D "pll1" }, > + { .index =3D -1, .name =3D "pll2" }, These two should come from DT via index as well. The binding should be changed to list the pll. In the previous review you mentioned the SoC driver was populating these. The answer is yes that you should be providing an OF clk provider (and updating the binding) to provide those clks to this device node. Otherwise it won't be possible to describe the connection besides with the name fallback method, which is not desired. > +}; > +