From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3439DC282DD for ; Mon, 10 Jun 2019 08:45:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 09DE8207E0 for ; Mon, 10 Jun 2019 08:45:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.b="nSxgBY6U" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388711AbfFJIpG (ORCPT ); Mon, 10 Jun 2019 04:45:06 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:36556 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388571AbfFJIpE (ORCPT ); Mon, 10 Jun 2019 04:45:04 -0400 Received: by mail-wm1-f67.google.com with SMTP id u8so7305552wmm.1 for ; Mon, 10 Jun 2019 01:45:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id; bh=qNwGVD0v2tDJVOma8Me2tLXYHNv3uP9ayQAL5Zl5p8M=; b=nSxgBY6UD0ogbvDpleZuxipRQtaVHmWNbd3+eNF78yabI2JIsfMO39rdkJuMbNNNEe uIru4cBb1MmPcYWj/kOLluu1HIst5DczKJbRnNe3C7chIny78xJnJTbDtp/bTTC1rJ9A CmsykBhDqPh7Zez/O5wtjuOyEWDN1wnP4Jnzw4pIcLWrTRNn2YEDYEE0JRNkS8JYgE/M AjOs8MemHx6dr4ab2ob+j1UcCcxRGLyhd5CdXX244kUkBitDNEIpROnrP/ooYoi31a1c SkWZtppIKK3rhjmELkQWW0VubtKtcsVIwBvkvM4IJPb/n+25vEnNmktuAdmvI1nxggCR X/sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=qNwGVD0v2tDJVOma8Me2tLXYHNv3uP9ayQAL5Zl5p8M=; b=jhDq5ClEyA5mWuhEV6CBFOkWJlHYeW55jOHJeWJkcPnqLu7oCCSUGHhIfk7CUQN/oh 5ihT3o8dVEdm7eBRoepklro2XyWvEJfrnJaExbsy1PsB25hyA6t6484OIpynvh60VHCH +68HABbU4Ae4/MeHkGBcntHx2SDAy5HLZb/pnX8Oppfuv+WB7x5c6nbAN48WfDnHNRSU mTptvHmT1elpPgA/LWXX4fwWaERPlcBa94quRrVa2l11I13epazPkoqhTHtgb/IHMnpd 3vkWv6mHldzkkE/ADMHWsP66JvukVY1m6U8jahit4iugHHKdViljzamfROVo6O49/opP PGuw== X-Gm-Message-State: APjAAAVU21AZI/5GZkjVbNmpFx22lazpWJ3UjomAJj7NzsVBlEuU2IwP CI1GgCBAbtxmE8ILhJen0wQz7Sg0GHMNWw== X-Google-Smtp-Source: APXvYqzqd62YGTXD2QtIldC59KTmIjNitmODkstbY2lZa1eC733LOO1gBiQtxJ40qqkDdHCG3xx5MQ== X-Received: by 2002:a1c:750d:: with SMTP id o13mr12156907wmc.35.1560156301810; Mon, 10 Jun 2019 01:45:01 -0700 (PDT) Received: from localhost (nat-35.starnet.cz. [178.255.168.35]) by smtp.gmail.com with ESMTPSA id j132sm17445435wmj.21.2019.06.10.01.45.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Jun 2019 01:45:01 -0700 (PDT) From: Michal Simek To: linux-kernel@vger.kernel.org, monstr@monstr.eu, michal.simek@xilinx.com, johan@kernel.org, gregkh@linuxfoundation.org Cc: Nava kishore Manne , Jiri Slaby , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] serial: xilinx_uartps: Fix warnings in the driver Date: Mon, 10 Jun 2019 10:44:55 +0200 Message-Id: X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nava kishore Manne This patch fixes the below warning -->Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. -->macros should not use a trailing semicolon. -->line over 80 characters. -->void function return statements are not generally useful. -->Prefer 'unsigned int' to bare use of 'unsigned'. Signed-off-by: Nava kishore Manne Signed-off-by: Michal Simek --- Happy to split it if needed. --- drivers/tty/serial/xilinx_uartps.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 605354fd60b1..6af2886f5ba7 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -35,12 +35,12 @@ /* Rx Trigger level */ static int rx_trigger_level = 56; -module_param(rx_trigger_level, uint, S_IRUGO); +module_param(rx_trigger_level, uint, 0444); MODULE_PARM_DESC(rx_trigger_level, "Rx trigger level, 1-63 bytes"); /* Rx Timeout */ static int rx_timeout = 10; -module_param(rx_timeout, uint, S_IRUGO); +module_param(rx_timeout, uint, 0444); MODULE_PARM_DESC(rx_timeout, "Rx timeout, 1-255"); /* Register offsets for the UART. */ @@ -199,7 +199,7 @@ struct cdns_platform_data { u32 quirks; }; #define to_cdns_uart(_nb) container_of(_nb, struct cdns_uart, \ - clk_rate_change_nb); + clk_rate_change_nb) /** * cdns_uart_handle_rx - Handle the received bytes along with Rx errors. @@ -312,7 +312,8 @@ static void cdns_uart_handle_tx(void *dev_id) } else { numbytes = port->fifosize; while (numbytes && !uart_circ_empty(&port->state->xmit) && - !(readl(port->membase + CDNS_UART_SR) & CDNS_UART_SR_TXFULL)) { + !(readl(port->membase + CDNS_UART_SR) & + CDNS_UART_SR_TXFULL)) { /* * Get the data from the UART circular buffer * and write it to the cdns_uart's TX_FIFO @@ -1073,8 +1074,6 @@ static void cdns_uart_poll_put_char(struct uart_port *port, unsigned char c) cpu_relax(); spin_unlock_irqrestore(&port->lock, flags); - - return; } #endif -- 2.17.1