From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D8591DEFD6 for ; Wed, 29 Jan 2025 16:44:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738169076; cv=none; b=FJ8IbG9ura9yBEwPeZKM1ULO3+b6LCO6AobzGcVirHu2BFmdxHI7dxzDrx4W+sv++XCqjOwnUt40tDxl4m6lafvVh7YcRqQZ9a7Ic/hkO/vJSOblBIal44IEFmAGbq1H5kpg3L77PUdMfruErjvu0tnuQX60/XQ4gJJMzgd7MgY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738169076; c=relaxed/simple; bh=G/d0ylaPtSDIjrsaz7JboseXa3SpoQ9S6bnX3JlVGuk=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=omMptwRRaKKqvIJJvG0ex/XZexKPvRbeCkeDziOBd0dU99ELIxqBqQe5NaIomAGhSIl8QiKyUjngXwQLifZGGFUIQAEEmQ45yurT+aLkgg92zX5B1JPvYUxsn2/zVIBCy95XjuIj99Z9NFfWugc+3HuMVtCUvU1ryHMt3ZqwnpI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bVRqUFk5; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bVRqUFk5" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4363ae65100so79647435e9.0 for ; Wed, 29 Jan 2025 08:44:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738169072; x=1738773872; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=s+P+kQEK9FrLYE8x2tbLZXPIt8MJ5MgVTvHDKiGvbJ0=; b=bVRqUFk5NAsej+bOJsqSTsyDhniLWa7OgG5EOj9GMfMe26/bKqPuW3tYIymPDtMlxu VgvuQ5hVRIHNcZdIxQYEGqZ4EjvDN9dEksGMUCiFazJAiu2OAbHltTa8UX6FHWpCBv3K K+Te3luMveiJK0uroMeR7lLMRbjI+6Shk9o3GvtHpCPC0oOaV2+1Xt+fk8GMJto2GGmm U0Lwqvn9dGkvRMw/RJY/qdISUEzthg/HSB07P/bGMuvgJerBvy2ilC+tSxAWBMM7Rccm hVsiGxUxsdRyIpPlKE6N3VDtbbxeLAMacklGK6Q695TqSuu+p5jgYujBAej7ptFdGsTv 9Nxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738169072; x=1738773872; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=s+P+kQEK9FrLYE8x2tbLZXPIt8MJ5MgVTvHDKiGvbJ0=; b=SbQOJLBGvfgOHvoi6w57WCvk8bjsOFyNxsH6rTIqgJRakwA2zCBzyjXYP19LGbZPbe LuQuHWytuq3HiuqcZG8KzXUhlcVOi+ykGEpJQyEgV3qy1Jp2Xe+8TUm2Q5pk2XLKfgFL S6NPyrrhhgRqXEmTQEAiTg/qwvef7GTef7ST2Eklg7aOkDEtzT9Z2Ih1gfnqmBoz1k2R 3bDnCYiHheRaw+rUyZKCHyEpJoktCLpDuPpyKOTLUpXOIQU/JqxWhlhGx8uvQ3ofplZL /aDkKP9UXmaM2OwcyHDfrgxdFTHf/v182yDxpKm5pcZar1nN5/d58TbPRDQ1fVWd2GfC A7Ug== X-Forwarded-Encrypted: i=1; AJvYcCUDd0kiIKRYhbhWcDIwLHWlxZcriPJEziSpEE+v8VvwCqElBBjUhLGXNiJyunU3D1pMBF8nbneO+OHzkyQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzdAHbelD/m4ssYb5ou8ZKzSDT0WbWM5bOlOxLg7wVzHmd2YepP UUjAgxOJzFrp2xhku9mqZ3I9bie5TowmGMgVBPeTkSNEA99j7O9epZjGPBBqQfw= X-Gm-Gg: ASbGncv/5wWMP47jqps+2D8K0nGsTJ9NyMzx+qMHyoq6c+NQY4Kp/kiGtj7za7L249b oTkWD5w30sbulwkWjPYTLA/dyl4+Zkv73E2sv2IIsbRJCOUpTEP2nBRP9B4o3EGpcxszccmRpG1 ZgAxHD36wncvpVO3wYvXv7BqFxbrEDBdhvU9yso4cf/809S3JXHDLHNFt1Nofw0IHoi8GOpglPS 9htSlt7merLOraH0sRi2Df3AlgE0LAPr9urpAfo5d9FdManGuDfr5egTUhH9kGP7W9fNDct1gRV p6jrW6Cg+s0x025Mz7tHR6lPmE7gkdNGdNDLbD7o3VgrY+CUmc6msWRuMnQFKZJ/wR48 X-Google-Smtp-Source: AGHT+IGU+0apyU+mgIHTYWjC+/davOqZgpQBPDsbDYK1OSLnbxtCNBsrhJypFLuT+lEu1zN6aBPDYw== X-Received: by 2002:a05:600c:4e07:b0:436:e86e:e4ab with SMTP id 5b1f17b1804b1-438dc4353e7mr41981115e9.30.1738169072304; Wed, 29 Jan 2025 08:44:32 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:b25e:a614:863b:566e? ([2a01:e0a:982:cbb0:b25e:a614:863b:566e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a1bad87sm17562458f8f.74.2025.01.29.08.44.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2025 08:44:31 -0800 (PST) Message-ID: Date: Wed, 29 Jan 2025 17:44:31 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v3 08/10] drm/display: bridge-connector: handle CEC adapters To: Dmitry Baryshkov , Maxime Ripard Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Dave Stevenson , =?UTF-8?Q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20250126-drm-hdmi-connector-cec-v3-0-5b5b2d4956da@linaro.org> <20250126-drm-hdmi-connector-cec-v3-8-5b5b2d4956da@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 29/01/2025 00:44, Dmitry Baryshkov wrote: > On Tue, Jan 28, 2025 at 05:14:06PM +0100, Maxime Ripard wrote: >> On Sun, Jan 26, 2025 at 03:29:13PM +0200, Dmitry Baryshkov wrote: >>> /* ----------------------------------------------------------------------------- >>> * Bridge Connector Initialisation >>> */ >>> @@ -633,6 +711,21 @@ struct drm_connector *drm_bridge_connector_init(struct drm_device *drm, >>> if (ret) >>> return ERR_PTR(ret); >>> } >>> + >>> + if (bridge->hdmi_cec_adapter_name) { >>> + if (!bridge->funcs->hdmi_cec_enable || >>> + !bridge->funcs->hdmi_cec_log_addr || >>> + !bridge->funcs->hdmi_cec_transmit) >>> + return ERR_PTR(-EINVAL); >>> + >>> + ret = drm_connector_hdmi_cec_register(connector, >>> + &drm_bridge_connector_hdmi_cec_ops, >>> + bridge->hdmi_cec_adapter_name, >>> + bridge->hdmi_cec_available_las, >>> + bridge->hdmi_dev); >>> + if (ret) >>> + return ERR_PTR(ret); >>> + } >> >> Maybe we can use a different bridge feature flag to trigger the CEC code >> support instead? > > it is possible, but what is the possible usecase? DP drivers should be > using DP_AUX CEC instead. And I think there are no other kinds of > bridges which implement CEC support. Meson driver does something strange > by registering CEC notifier from meson_encoder_hdmi. I think instead > this should be moved to the DW HDMI bridge itself > It was done before bridge_connector has any support for CEC to keep the functionnality, I'll be happy to switch to this. Neil