From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A492385531 for ; Thu, 29 Jan 2026 12:23:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769689387; cv=none; b=GxS6638ZdRGOC6ljMXEf8n/J641ySZ+fHlAaHd+ZONwjsXLw0tkayZ2z4TxxMA0uLnSiBmSinXMgKDpau3Yr82cG1FQ+W+V9hv7l+27RGqvaCoqhbMdp/aDzLhfBcHThidwghzqDYgQzmJzqiSTAmlbSfzLC4d/pTCpPElVCAmw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769689387; c=relaxed/simple; bh=jdbH00HnNju74dBpAsXf7ufwLvO5prtWz5fSqnJYxcI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qf/w3SNPaGmCfKoesnWUUVvsV00VAgsLg1KZ/kjQXzwkdT/RLKsicbixKuucbFqBzZhU0BgFKJOmKqCcpN/CCBNvIY4tzmgwPRqyGb/T7cQjgStEjNOo26hUgo4VA3FtSTaz150pdXTStHm4Fwwyv8Z1/Re4dk7C75E62d3A044= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RENB0jQN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ic4+Xhgw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RENB0jQN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ic4+Xhgw" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60TAjsHd1429062 for ; Thu, 29 Jan 2026 12:23:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fLts6ISuue4uiGMT8/YFzy9kgsEvBZLokoaOLt1tYBg=; b=RENB0jQNan7XNKgf eyF8aSZ01hBaxySmx8WIC2trIEL/ATD7/lVY5PJhFqE0XWRXw3bxCWJ1IzA6QxNj WleBXxBEuRVsencj8XsgiHekt5wkvfMeNfPds2ljHp3Y4Xt2Jd1sGkxZlA9rwab/ QNpG2rFdAQA1RUwMKOsieLyw7o3SGYoJBV0y2FcZ7dw/UtSy9It8CpMcnisYEk+K u0H2jhvpg3BEcshgiRg3jUtM1W85ykxmBsES6qbMclW58rOKXDIDzAxs8UtJIbqZ m/tzXb7RPsNS7b70I5UrpmdI3bAbF5HzcQT/LhfFAb8ydNqtfDBSbdgMbZFaJrsV B7mjbw== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4byydh1jvc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 29 Jan 2026 12:23:05 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-894662cba4fso2606036d6.2 for ; Thu, 29 Jan 2026 04:23:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769689384; x=1770294184; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fLts6ISuue4uiGMT8/YFzy9kgsEvBZLokoaOLt1tYBg=; b=ic4+XhgwgQ3p/wLT8van2jgqwGmKQ8qCFLwadh6Ysfhh9/afmkuD7flMSlfoD80ygl f2+hakyjK5AJ0ipk0+LbwUKw84Mh4ZvVLa5wjgU2VWvtvnZt1oIgKiq54PUpC5vVCkCw yT6ifoaPgrb1kli1U2SEZrdypLRSH9vGVsssYQ3DdEGYPTfr+bLP00v9RMNlTd08ZADb EvMSvrKhkHnt+j6/3ASXxrJ2qvvvOC1Kh0GCH+4Tf+iPXZ2/8AFIQs7015yhSmUBzk4D jgBXdvbSishE4NKvKKQIndFoqHBudZCV76UmL9mebythvATqpEVS2gJD1tP512KMuHuB /PVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769689384; x=1770294184; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fLts6ISuue4uiGMT8/YFzy9kgsEvBZLokoaOLt1tYBg=; b=Y3mbkTYM7AyPZ1/Yz7Az6j2AzVQFdGjYXsfDLy8P5sCnk52dy1l7SnVyme7W0sQx3G egD+sK635kykuKI+ET5ODe2TZnRXAbGHnH6NzH822FGTf2ThuMVIhpgtSkfgTFe0OW2b DQC4Usig1GOa+3UKqc1bvgzXtxUVPyakH5QI9N185JZl9tRG6Ws8WJPVidRvNmtEsd7+ Cr9maoaxgKiBdNdNuT/To2IPHaUZwbaF15yufS8s1qzvQKPd2glYFkBsLcO40ht+vW++ rMlt1D8xYTX0jgFa90L+jO7m56+2E/prQSGqXBgSt/SaAxYE1lVi8JZ4RzKtmbANCDmo 1tRA== X-Forwarded-Encrypted: i=1; AJvYcCXEMI4jYWY4lYBTRhGTzx56XZ9KqdXOSlSLvBDMFheWlLW4wu5gP5W8zOar9gDRfaTTEKd7ApAM+O0CSDQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxpY4n7Vh32GLXTvfFq84C5o3HEhNFrIbKRFfKuk+RB7VHVtCIg hSlnX/aA1MTaJ/kLuRowMppWYlWz8iKErWzspiHi09CUgEwVM/DO47KqZna1NCm2E2AfaAPnOiu 2dGxcluwyWQpczKVSUErS9Kd4V5k/w1BUfcx2+CwJmccuirG0rZbYgGDC5lksCLto+b8= X-Gm-Gg: AZuq6aJL2gSkUQlZcs9yJm0x92UTOv1f0HQ6Mwefj98BIoQeOdWnIO3gBy99MPFYHOu R9PGbH4HhqYQMxdn14Y4uw4xn5I38gtvZNU6AQrl4azgPRgVmTwbfRniJpWKL+rgJK9ig82BlCV f19seDpQeTfjlDEO9V1Te0XSmHzqo3BayeD+37qLUbe6lW+69q3RGoqOQccpUicmQLtt72jW6DW r/EyrlD4XQxMiCxat9W5XYDfHnzeVGCR+5dKdDqe5X9koWSoYikMxyeH3jk9uKLlm4iX7df1mig +dUuM1Aii8xnSyXmVlPlX3C2rZpac9yKri4z24TrZtbQah0X8AkCvXphupM6CIcICMG7o3h/Omn dR+1h1Xgk8EB3T9FSd6mpG2zkm3bnS4qnGgQc7LVKgrbSc03kXgMfwX0um0eDGmkHcgw= X-Received: by 2002:a05:620a:700b:b0:8c6:a707:dae7 with SMTP id af79cd13be357-8c71ac32e95mr362599085a.1.1769689384232; Thu, 29 Jan 2026 04:23:04 -0800 (PST) X-Received: by 2002:a05:620a:700b:b0:8c6:a707:dae7 with SMTP id af79cd13be357-8c71ac32e95mr362596885a.1.1769689383816; Thu, 29 Jan 2026 04:23:03 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-658b4256a35sm2829564a12.1.2026.01.29.04.23.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 04:23:03 -0800 (PST) Message-ID: Date: Thu, 29 Jan 2026 13:23:00 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] arm64: dts: qcom: ipq9574: Add gpio details for eMMC To: Varadarajan Narayanan , andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: sumit.garg@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com References: <20260129062825.666457-1-varadarajan.narayanan@oss.qualcomm.com> <20260129062825.666457-2-varadarajan.narayanan@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260129062825.666457-2-varadarajan.narayanan@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 39YUoHCD3aIO50DglFZ2V8qikv7K6Ep5 X-Proofpoint-ORIG-GUID: 39YUoHCD3aIO50DglFZ2V8qikv7K6Ep5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI5MDA4NCBTYWx0ZWRfXw8Gu+h+s9aKw nxH+Oid4U1owQ4TgXwLoo0xunRUCSr1XagvRfoFGLJ016ikudXjMhC3hbC5Y0QnMEC9Xrow6iWq 8IAjEWJTLnFWE3a0/af3ZbJF48ruTiC7G0gtkDa7Cy8ePtOd9gdoIh6yr+jQGeaKDB7qELpmPqQ egFUvvkbfprMh5D2XIhERW5oDakYyt9JAxy/UoXCZcLz0abPlJ9F3ZW0vOtO3WMgB4EmhyycL4T tD7BPqYVnocznP4EItXGmxVIdVpLgfQVHVSU//yNefKiILj72E+hfsOxpRcDutHpgjNqBqQhEET DIwC8prvSm37GsfyCdMkZiZkeg1ZIpweD8Ihgc0jExH1YjqQQU4BPQNLmB4DBNpOJRBfeXky5h0 EjNhSnHgUQgSDJ62t2iS2S0mifmwNofsQgT0yXId0kDNibJalkucnM5gsaHEqbkhQuaDeGFBPis LMOrmylv4wLUEY9uw4w== X-Authority-Analysis: v=2.4 cv=Cs6ys34D c=1 sm=1 tr=0 ts=697b5129 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=aDU20HDKTo6PiRKR8JcA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-29_02,2026-01-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 spamscore=0 phishscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 adultscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601290084 On 1/29/26 7:28 AM, Varadarajan Narayanan wrote: > The RDP433 has NAND and eMMC variants. Presently, only NAND variant is > supported. To enable support for eMMC variant, add the relevant GPIO > related information. > > Do not enable NAND by default here. Enable it in board specific DTS. > > Reviewed-by: Konrad Dybcio > Signed-off-by: Varadarajan Narayanan > --- > v3: Disable nand in ipq9574-rdp-common.dtsi and enable it where required. > Add 'Reviewed-by: Konrad Dybcio' > --- [...] > &qpic_bam { > @@ -179,7 +211,7 @@ &qpic_nand { > pinctrl-0 = <&qpic_snand_default_state>; > pinctrl-names = "default"; > > - status = "okay"; > + status = "disabled"; This part should apply to the second patch, since you now broke NAND for every board that had it running previously by disabling it in the common DTSI and not immediately overriding it back. This must not happen, since it impacts bisectability of the kernel tree The solution is to squash this hunk above (not the addition of eMMC GPIOs) with patch 3. You can also drop the status=disabled in common.dtsi, since it's already disabled in the SoC dtsi. Konrad