From: Zijun Hu <zijun_hu@icloud.com>
To: Christian Brauner <brauner@kernel.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
David Howells <dhowells@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Zijun Hu <quic_zijuhu@quicinc.com>
Subject: Re: [PATCH 2/5] fs/fs_parse: Fix macro fsparam_u32hex() definition
Date: Fri, 11 Apr 2025 22:25:56 +0800 [thread overview]
Message-ID: <c67dfd96-ae7c-4c10-8e80-70b9df566ccf@icloud.com> (raw)
In-Reply-To: <20250411-kinokarten-umweltschutz-6167b202db91@brauner>
On 2025/4/11 22:17, Christian Brauner wrote:
>> diff --git a/include/linux/fs_parser.h b/include/linux/fs_parser.h
>> index 53e566efd5fd133d19e313e494b975612a227b77..ca76601d0bbdbaded76515cb6b2c06fa30127a06 100644
>> --- a/include/linux/fs_parser.h
>> +++ b/include/linux/fs_parser.h
>> @@ -126,7 +126,7 @@ static inline bool fs_validate_description(const char *name,
>> #define fsparam_u32oct(NAME, OPT) \
>> __fsparam(fs_param_is_u32, NAME, OPT, 0, (void *)8)
>> #define fsparam_u32hex(NAME, OPT) \
>> - __fsparam(fs_param_is_u32_hex, NAME, OPT, 0, (void *)16)
>> + __fsparam(fs_param_is_u32, NAME, OPT, 0, (void *)16)
> Remove that define completely as it's unused. There's no point keeping
> dead code around.
sure. will do it. (^^)
next prev parent reply other threads:[~2025-04-11 14:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 11:45 [PATCH 0/5] fs: bug fixes Zijun Hu
2025-04-10 11:45 ` [PATCH 1/5] fs/filesystems: Fix potential unsigned integer underflow in fs_name() Zijun Hu
2025-04-11 14:34 ` (subset) " Christian Brauner
2025-04-11 14:35 ` Christian Brauner
2025-04-11 14:52 ` Zijun Hu
2025-04-10 11:45 ` [PATCH 2/5] fs/fs_parse: Fix macro fsparam_u32hex() definition Zijun Hu
2025-04-11 14:17 ` Christian Brauner
2025-04-11 14:25 ` Zijun Hu [this message]
2025-04-10 11:45 ` [PATCH 3/5] fs/fs_parse: Fix 3 issues for validate_constant_table() Zijun Hu
2025-04-11 14:37 ` Christian Brauner
2025-04-11 14:48 ` Zijun Hu
2025-04-14 12:39 ` Jan Kara
2025-04-10 11:45 ` [PATCH 4/5] fs/fs_parse: Correct comments of fs_validate_description() Zijun Hu
2025-04-11 14:20 ` (subset) " Christian Brauner
2025-04-10 11:45 ` [PATCH 5/5] fs/fs_context: Mark an unlikely if condition with unlikely() in vfs_parse_monolithic_sep() Zijun Hu
2025-04-11 14:24 ` (subset) " Christian Brauner
2025-04-11 15:34 ` [PATCH 1/5] fs/filesystems: Fix potential unsigned integer underflow in fs_name() David Howells
2025-04-11 16:06 ` Zijun Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c67dfd96-ae7c-4c10-8e80-70b9df566ccf@icloud.com \
--to=zijun_hu@icloud.com \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_zijuhu@quicinc.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®